Re: Re: [PATCH v1 2/2] ARM: dts: rockchip: set dr_mode property for rk3288-firefly board

[李云志 <lyz@rock-chips.com>]

[-- Attachment #1: Type: text/plain, Size: 1786 bytes --]

Hi Heiko:

    I thought the Firefly board has a USB type A receptacle connector for otg like chromebook, but actually Firefly board use a micro-B connector.
If some board use a type A connector for otg port then it should add a dr_mode = "host" property beacuse type A connector not connect usb-id
pin to soc.
    So please ignore this patch, it's my mistake .



李云志
 
From: HeikoStübner
Date: 2015-04-26 18:16
To: Yunzhi Li
CC: cf; hl; yk; gauravsh; alberto; wulf; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; Russell King; linux-arm-kernel; linux-rockchip; devicetree; linux-kernel
Subject: Re: [PATCH v1 2/2] ARM: dts: rockchip: set dr_mode property for rk3288-firefly board
Hi,
 
Am Sonntag, 26. April 2015, 17:41:39 schrieb Yunzhi Li:
> rk3288-firefly board use the dwc2 usb otg controller as a host
> controller and the device mode not used, so the dr_mode should be
> "host" then the dwc2 usb otg controller will work at host only
> mode
> 
> Signed-off-by: Yunzhi Li <lyz@rock-chips.com>
 
Not sure I understand. Is this some sort of hardware limitation? Because when 
for example flashing a kernel via upgrade_tool it is working just fine as 
gadget.
 
If it is a software choice, this should not be made in the devicetree, as the 
dt describes the hardware alone.
 
 
Heiko
 
 
> 
> ---
> 
>  arch/arm/boot/dts/rk3288-firefly.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-firefly.dtsi
> b/arch/arm/boot/dts/rk3288-firefly.dtsi index e6f873a..a861776 100644
> --- a/arch/arm/boot/dts/rk3288-firefly.dtsi
> +++ b/arch/arm/boot/dts/rk3288-firefly.dtsi
> @@ -466,6 +466,7 @@
>  };
> 
>  &usb_otg {
> + dr_modr = "host";
>  status = "okay";
>  };
 
 
 

[-- Attachment #2: Type: text/html, Size: 5198 bytes --]