All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Jiri Slaby <jslaby@suse.cz>, David Miller <davem@davemloft.net>,
	ML netdev <netdev@vger.kernel.org>,
	stable@vger.kernel.org
Subject: Re: v3.12-stable-queue build errors
Date: Mon, 27 Apr 2015 09:17:03 -0700	[thread overview]
Message-ID: <20150427161703.GC14248@roeck-us.net> (raw)
In-Reply-To: <87fv7lk2i0.fsf@x220.int.ebiederm.org>

On Mon, Apr 27, 2015 at 10:35:51AM -0500, Eric W. Biederman wrote:
> Jiri Slaby <jslaby@suse.cz> writes:
> 
> > On 04/25/2015, 04:16 PM, Guenter Roeck wrote:
> >> Several powerpc build fail with:
> >> 
> >> drivers/net/ethernet/freescale/gianfar.c: In function 'gfar_start_xmit':
> >> drivers/net/ethernet/freescale/gianfar.c:2146:3: error: implicit declaration of
> >> function 'dev_consume_skb_any' [-Werror=implicit-function-declaration]
> >>    dev_consume_skb_any(skb);
> >> 
> >> dev_consume_skb_any() does not exist in 3.12.
> >> 
> >> Introduced by 'gianfar: Carefully free skbs in functions called by netpoll'.
> >
> > Eric, David,
> >
> > what action should I take here?
> >
> > 1) take also:
> > commit e6247027e5173c00efb2084d688d06ff835bc3b0
> > Author: Eric Dumazet <edumazet@google.com>
> > Date:   Thu Dec 5 04:45:08 2013 -0800
> >
> >     net: introduce dev_consume_skb_any()
> >
> >
> > 2) drop 'gianfar: Carefully free skbs in functions called by netpoll'
> > from stable-3.12
> 
> This is probably the most reasonable.   KISS.
> 
Greg dropped the patch from 3.10. 

Guenter

  reply	other threads:[~2015-04-27 16:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150425141609.GA1147@roeck-us.net>
2015-04-27  8:45 ` v3.12-stable-queue build errors Jiri Slaby
2015-04-27 15:35   ` Eric W. Biederman
2015-04-27 16:17     ` Guenter Roeck [this message]
2015-04-27 16:25     ` David Miller
2015-04-27 18:00       ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150427161703.GC14248@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=jslaby@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.