All of lore.kernel.org
 help / color / mirror / Atom feed
From: dac.override@gmail.com (Dominick Grift)
To: refpolicy@oss.tresys.com
Subject: [refpolicy] [PATCH] Role type statements no longer declare the role
Date: Mon, 27 Apr 2015 20:05:35 +0200	[thread overview]
Message-ID: <20150427180534.GA27157@x131e> (raw)
In-Reply-To: <1430157783-27471-1-git-send-email-dac.override@gmail.com>

On Mon, Apr 27, 2015 at 08:03:03PM +0200, Dominick Grift wrote:
> Back in the older days, role type statements automatically declared the role. This was later changed.
> 
> I expect that these macro date from that period and that they should be updated to declare the role.

This is just a RFC patch. its untested and the indent is not conform refpolicy style rules

just want to hear opinions

> ---
>  policy/modules/system/userdomain.if | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/policy/modules/system/userdomain.if b/policy/modules/system/userdomain.if
> index 5f71587..9269135 100644
> --- a/policy/modules/system/userdomain.if
> +++ b/policy/modules/system/userdomain.if
> @@ -27,11 +27,11 @@ template(`userdom_base_user_template',`
>  		attribute userdomain;
>  		type user_devpts_t, user_tty_device_t;
>  		class context contains;
> -		role $1_r;
>  	')
>  
>  	attribute $1_file_type;
>  
> +    role $1_r;
>  	type $1_t, userdomain;
>  	domain_type($1_t)
>  	corecmd_shell_entry_type($1_t)
> -- 
> 2.3.6
> 

-- 
02DFF788
4D30 903A 1CF3 B756 FB48  1514 3148 83A2 02DF F788
http://keys.gnupg.net/pks/lookup?op=vindex&search=0x314883A202DFF788
Dominick Grift
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 648 bytes
Desc: not available
Url : http://oss.tresys.com/pipermail/refpolicy/attachments/20150427/2e02f6a4/attachment.bin 

  reply	other threads:[~2015-04-27 18:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27 18:03 [refpolicy] [PATCH] Role type statements no longer declare the role Dominick Grift
2015-04-27 18:05 ` Dominick Grift [this message]
2015-04-27 18:55   ` Sven Vermeulen
2015-04-27 19:05     ` Dominick Grift
2015-04-27 19:07     ` Christopher J. PeBenito

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150427180534.GA27157@x131e \
    --to=dac.override@gmail.com \
    --cc=refpolicy@oss.tresys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.