All of lore.kernel.org
 help / color / mirror / Atom feed
From: lee@kernel.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: BCM2835: Skip doing our own iotable_init() initialization.
Date: Mon, 27 Apr 2015 19:25:26 +0100	[thread overview]
Message-ID: <20150427182526.GD11956@x1> (raw)
In-Reply-To: <1429811351-12600-1-git-send-email-eric@anholt.net>

On Thu, 23 Apr 2015, Eric Anholt wrote:

> The only thing we were using this 16MB mapping of IO peripherals for
> was the uart's early debug mapping.  If we just drop the map_io hook,
> the kernel will call debug_ll_io_init() for us, which maps the single
> page needed for the device.
> 
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>  arch/arm/mach-bcm/board_bcm2835.c | 17 -----------------
>  1 file changed, 17 deletions(-)

Applied with Stephen's Ack.

> diff --git a/arch/arm/mach-bcm/board_bcm2835.c b/arch/arm/mach-bcm/board_bcm2835.c
> index 70f2f39..9851ee8 100644
> --- a/arch/arm/mach-bcm/board_bcm2835.c
> +++ b/arch/arm/mach-bcm/board_bcm2835.c
> @@ -31,10 +31,6 @@
>  #define PM_RSTC_WRCFG_FULL_RESET	0x00000020
>  #define PM_RSTS_HADWRH_SET		0x00000040
>  
> -#define BCM2835_PERIPH_PHYS	0x20000000
> -#define BCM2835_PERIPH_VIRT	0xf0000000
> -#define BCM2835_PERIPH_SIZE	SZ_16M
> -
>  static void __iomem *wdt_regs;
>  
>  /*
> @@ -93,18 +89,6 @@ static void bcm2835_power_off(void)
>  	bcm2835_restart(REBOOT_HARD, "");
>  }
>  
> -static struct map_desc io_map __initdata = {
> -	.virtual = BCM2835_PERIPH_VIRT,
> -	.pfn = __phys_to_pfn(BCM2835_PERIPH_PHYS),
> -	.length = BCM2835_PERIPH_SIZE,
> -	.type = MT_DEVICE
> -};
> -
> -static void __init bcm2835_map_io(void)
> -{
> -	iotable_init(&io_map, 1);
> -}
> -
>  static void __init bcm2835_init(void)
>  {
>  	int ret;
> @@ -129,7 +113,6 @@ static const char * const bcm2835_compat[] = {
>  };
>  
>  DT_MACHINE_START(BCM2835, "BCM2835")
> -	.map_io = bcm2835_map_io,
>  	.init_irq = irqchip_init,
>  	.init_machine = bcm2835_init,
>  	.restart = bcm2835_restart,

      parent reply	other threads:[~2015-04-27 18:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23 17:49 [PATCH] ARM: BCM2835: Skip doing our own iotable_init() initialization Eric Anholt
2015-04-24  3:28 ` Stephen Warren
2015-04-27 18:25 ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150427182526.GD11956@x1 \
    --to=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.