From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3 1/3] mfd: provide RTC resource in MT6397 MFD Date: Tue, 28 Apr 2015 11:07:19 +0100 Message-ID: <20150428100719.GN11956@x1> References: <1430206556-18254-1-git-send-email-eddie.huang@mediatek.com> <1430206556-18254-2-git-send-email-eddie.huang@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1430206556-18254-2-git-send-email-eddie.huang@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: Eddie Huang Cc: Alessandro Zummo , Matthias Brugger , Andrew Morton , Tomasz Figa , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , srv_heupstream@mediatek.com, Samuel Ortiz , Greg KH , Joe Perches , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org On Tue, 28 Apr 2015, Eddie Huang wrote: > Provide MT6397 RTC interrupt, base address, and register in > MT6397 MFD. >=20 > Signed-off-by: Eddie Huang > --- > drivers/mfd/mt6397-core.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) *after* Uwe's concerns have been attended to, you may add my: Acked-by: Lee Jones =46WIW, I quite like straight lines. :) > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c > index 09bc780..08cfbd1 100644 > --- a/drivers/mfd/mt6397-core.c > +++ b/drivers/mfd/mt6397-core.c > @@ -21,9 +21,27 @@ > #include > #include > =20 > +#define MT6397_RTC_BASE 0xe000 > +#define MT6397_RTC_SIZE 0x3e > + > +static const struct resource mt6397_rtc_resources[] =3D { > + { > + .start =3D MT6397_RTC_BASE, > + .end =3D MT6397_RTC_BASE + MT6397_RTC_SIZE, > + .flags =3D IORESOURCE_MEM, > + }, > + { > + .start =3D MT6397_IRQ_RTC, > + .end =3D MT6397_IRQ_RTC, > + .flags =3D IORESOURCE_IRQ, > + }, > +}; > + > static const struct mfd_cell mt6397_devs[] =3D { > { > .name =3D "mt6397-rtc", > + .num_resources =3D ARRAY_SIZE(mt6397_rtc_resources), > + .resources =3D mt6397_rtc_resources, > .of_compatible =3D "mediatek,mt6397-rtc", > }, { > .name =3D "mt6397-regulator", --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com. [209.85.212.178]) by gmr-mx.google.com with ESMTPS id bc3si564122wib.2.2015.04.28.03.07.23 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Apr 2015 03:07:23 -0700 (PDT) Received: by mail-wi0-f178.google.com with SMTP id f7so13157874wie.0 for ; Tue, 28 Apr 2015 03:07:23 -0700 (PDT) Date: Tue, 28 Apr 2015 11:07:19 +0100 From: Lee Jones To: Eddie Huang Cc: Alessandro Zummo , Matthias Brugger , Andrew Morton , Tomasz Figa , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , srv_heupstream@mediatek.com, Samuel Ortiz , Greg KH , Joe Perches , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [rtc-linux] Re: [PATCH v3 1/3] mfd: provide RTC resource in MT6397 MFD Message-ID: <20150428100719.GN11956@x1> References: <1430206556-18254-1-git-send-email-eddie.huang@mediatek.com> <1430206556-18254-2-git-send-email-eddie.huang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1430206556-18254-2-git-send-email-eddie.huang@mediatek.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Tue, 28 Apr 2015, Eddie Huang wrote: > Provide MT6397 RTC interrupt, base address, and register in > MT6397 MFD. >=20 > Signed-off-by: Eddie Huang > --- > drivers/mfd/mt6397-core.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) *after* Uwe's concerns have been attended to, you may add my: Acked-by: Lee Jones FWIW, I quite like straight lines. :) > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c > index 09bc780..08cfbd1 100644 > --- a/drivers/mfd/mt6397-core.c > +++ b/drivers/mfd/mt6397-core.c > @@ -21,9 +21,27 @@ > #include > #include > =20 > +#define MT6397_RTC_BASE 0xe000 > +#define MT6397_RTC_SIZE 0x3e > + > +static const struct resource mt6397_rtc_resources[] =3D { > + { > + .start =3D MT6397_RTC_BASE, > + .end =3D MT6397_RTC_BASE + MT6397_RTC_SIZE, > + .flags =3D IORESOURCE_MEM, > + }, > + { > + .start =3D MT6397_IRQ_RTC, > + .end =3D MT6397_IRQ_RTC, > + .flags =3D IORESOURCE_IRQ, > + }, > +}; > + > static const struct mfd_cell mt6397_devs[] =3D { > { > .name =3D "mt6397-rtc", > + .num_resources =3D ARRAY_SIZE(mt6397_rtc_resources), > + .resources =3D mt6397_rtc_resources, > .of_compatible =3D "mediatek,mt6397-rtc", > }, { > .name =3D "mt6397-regulator", --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 28 Apr 2015 11:07:19 +0100 Subject: [PATCH v3 1/3] mfd: provide RTC resource in MT6397 MFD In-Reply-To: <1430206556-18254-2-git-send-email-eddie.huang@mediatek.com> References: <1430206556-18254-1-git-send-email-eddie.huang@mediatek.com> <1430206556-18254-2-git-send-email-eddie.huang@mediatek.com> Message-ID: <20150428100719.GN11956@x1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 28 Apr 2015, Eddie Huang wrote: > Provide MT6397 RTC interrupt, base address, and register in > MT6397 MFD. > > Signed-off-by: Eddie Huang > --- > drivers/mfd/mt6397-core.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) *after* Uwe's concerns have been attended to, you may add my: Acked-by: Lee Jones FWIW, I quite like straight lines. :) > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c > index 09bc780..08cfbd1 100644 > --- a/drivers/mfd/mt6397-core.c > +++ b/drivers/mfd/mt6397-core.c > @@ -21,9 +21,27 @@ > #include > #include > > +#define MT6397_RTC_BASE 0xe000 > +#define MT6397_RTC_SIZE 0x3e > + > +static const struct resource mt6397_rtc_resources[] = { > + { > + .start = MT6397_RTC_BASE, > + .end = MT6397_RTC_BASE + MT6397_RTC_SIZE, > + .flags = IORESOURCE_MEM, > + }, > + { > + .start = MT6397_IRQ_RTC, > + .end = MT6397_IRQ_RTC, > + .flags = IORESOURCE_IRQ, > + }, > +}; > + > static const struct mfd_cell mt6397_devs[] = { > { > .name = "mt6397-rtc", > + .num_resources = ARRAY_SIZE(mt6397_rtc_resources), > + .resources = mt6397_rtc_resources, > .of_compatible = "mediatek,mt6397-rtc", > }, { > .name = "mt6397-regulator", -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog