From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: James Hogan <james.hogan@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, Jiri Slaby <jslaby@suse.cz>,
linux-mips@linux-mips.org
Subject: Re: [PATCH 2/2] ttyFDC: Fix to use native endian MMIO reads
Date: Tue, 28 Apr 2015 13:15:56 +0200 [thread overview]
Message-ID: <20150428111556.GA16174@kroah.com> (raw)
In-Reply-To: <1430215050-4995-3-git-send-email-james.hogan@imgtec.com>
On Tue, Apr 28, 2015 at 10:57:30AM +0100, James Hogan wrote:
> The MIPS Common Device Memory Map (CDMM) is internal to the core and has
> native endianness. There is therefore no need to byte swap the accesses
> on big endian targets, so convert the Fast Debug Channel (FDC) TTY
> driver to use __raw_readl()/__raw_writel() rather than
> ioread32()/iowrite32().
>
> Fixes: 4cebec609aea ("TTY: Add MIPS EJTAG Fast Debug Channel TTY driver")
> Fixes: c2d7ef51d731 ("ttyFDC: Implement KGDB IO operations.")
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.cz>
> Cc: linux-mips@linux-mips.org
> ---
> drivers/tty/mips_ejtag_fdc.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
prev parent reply other threads:[~2015-04-28 11:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 9:57 [PATCH 0/2] MIPS: CDMM big endian fixes for v4.1 James Hogan
2015-04-28 9:57 ` James Hogan
2015-04-28 9:57 ` [PATCH 1/2] MIPS: Fix CDMM to use native endian MMIO reads James Hogan
2015-04-28 9:57 ` James Hogan
2015-04-28 9:57 ` [PATCH 2/2] ttyFDC: Fix " James Hogan
2015-04-28 9:57 ` James Hogan
2015-04-28 11:15 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150428111556.GA16174@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=james.hogan@imgtec.com \
--cc=jslaby@suse.cz \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.