All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glenn Golden <gdg@zplane.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Alex Hung <alex.hung@canonical.com>,
	Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	Raymond Yau <superquad.vortex2@gmail.com>,
	bruno.mueller@gmail.com,
	David Henningsson <david.henningsson@canonical.com>
Subject: Re: [pulseaudio-discuss] ThinkPad T-510 audio output mute LED non-workingness
Date: Tue, 28 Apr 2015 05:39:48 -0600	[thread overview]
Message-ID: <20150428113948.GN550@huh.zplane.com> (raw)
In-Reply-To: <s5h618gwnno.wl-tiwai@suse.de>

Takashi Iwai <tiwai@suse.de> [2015-04-28 12:30:19 +0200]:
> 
> Then it's likely an issue in thinkpad_acpi.c.  It implies that the
> driver couldn't get SSMS acpi handle.
> 

Raymond had pointed this out earlier as a (the?) patch that brought the static
tp_led_table led_tables[] into existence:

    http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/platform/x86/thinkpad_acpi.c?id=420f9739a62cdb027f5580d25c813501ff93aa6f

To my eyes, the table appears to be as it was in that patch:

    ---------------------------------------------------------------------------
    static struct tp_led_table led_tables[] = {
	    [TPACPI_LED_MUTE] = {
		    .name = "SSMS",
		    .on_value = 1,
		    .off_value = 0,
	    },
	    [TPACPI_LED_MICMUTE] = {
		    .name = "MMTS",
		    .on_value = 2,
		    .off_value = 0,
	    },
    };
    ---------------------------------------------------------------------------

thinkpad_acpi.h defines this enum and func:

    ---------------------------------------------------------------------------
    /* These two functions return 0 if success, or negative error code
       (e g -ENODEV if no led present) */

    enum {
	    TPACPI_LED_MUTE,
	    TPACPI_LED_MICMUTE,
	    TPACPI_LED_MAX,
    };

    int tpacpi_led_set(int whichled, bool on);
    ---------------------------------------------------------------------------

although I don't understand why the comment says "these TWO functions..."
since there's only one.

How to learn more about the source of LED_MUTE's evident non-existence in
my build? I guess I don't understand how the above "SSMS" entry in the table
is non-existent? Is there a function-pointer table/hash in which "SSMS" is
further used as a key?

> 
> For HD-audio, you need to unload the codec drivers at first, e.g.
> [ ... ]
>

Thanks, that will help a lot, as the machine is in constant use and
reboots are painful.

  reply	other threads:[~2015-04-28 11:39 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150418131002.GV562@huh.zplane.com>
     [not found] ` <CAN8cciZOgTzrTdp2m8Y+vPDrGVdO6y+WpXNfSF+pyuz9GswyqA@mail.gmail.com>
     [not found]   ` <20150419133733.GA551@huh.zplane.com>
     [not found]     ` <CAN8cciYqdJ-m+M0+F09115nocy7szAfgdAf834c2bS4=gL7DAA@mail.gmail.com>
     [not found]       ` <20150425013937.GB550@huh.zplane.com>
     [not found]         ` <1429974719.3937109.258484493.7D74FAC6@webmail.messagingengine.com>
     [not found]           ` <20150426152012.GE550@huh.zplane.com>
     [not found]             ` <s5hvbgiho2o.wl-tiwai@suse.de>
     [not found]               ` <CAN8cciZQBRz2Ty3YRt2+3KO9v1BWef-_8FU_d_SsE87mLdgY-w@mail.gmail.com>
     [not found]                 ` <s5hh9s2gj45.wl-tiwai@suse.de>
     [not found]                   ` <20150427135859.GI550@huh.zplane.com>
2015-04-27 17:12                     ` [pulseaudio-discuss] ThinkPad T-510 audio output mute LED non-workingness Takashi Iwai
2015-04-27 17:52                       ` Glenn Golden
2015-04-27 18:49                         ` Takashi Iwai
2015-04-28  0:22                           ` Glenn Golden
2015-04-28  0:02                       ` Glenn Golden
2015-04-28  6:06                         ` Takashi Iwai
2015-04-28 10:16                           ` Glenn Golden
2015-04-28 10:30                             ` Takashi Iwai
2015-04-28 11:39                               ` Glenn Golden [this message]
2015-04-28 11:50                                 ` Takashi Iwai
2015-04-28 17:53                                   ` Glenn Golden
2015-04-28 19:21                                     ` Takashi Iwai
2015-04-29 12:46                                       ` Glenn Golden
2015-04-29 13:09                                         ` Henrique de Moraes Holschuh
2015-04-29 17:41                                           ` Glenn Golden
2015-05-01 14:22                         ` Raymond Yau
2015-05-02 16:00                           ` Glenn Golden
2015-05-04 10:37                             ` Henrique de Moraes Holschuh
2015-05-04 12:26                               ` Glenn Golden
2015-05-04 13:16                                 ` Henrique de Moraes Holschuh
2015-05-07  0:15                                   ` Glenn Golden
2015-05-07  1:03                                     ` Raymond Yau
2015-05-07  1:47                                       ` Glenn Golden
2015-05-11 12:56                                     ` David Henningsson
2015-05-16 20:32                                       ` Glenn Golden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150428113948.GN550@huh.zplane.com \
    --to=gdg@zplane.com \
    --cc=alex.hung@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=bruno.mueller@gmail.com \
    --cc=david.henningsson@canonical.com \
    --cc=hmh@hmh.eng.br \
    --cc=superquad.vortex2@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.