From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 01/10] block: make generic_make_request handle arbitrarily sized bios Date: Tue, 28 Apr 2015 13:43:20 +0200 Message-ID: <20150428114320.GA9790@lst.de> References: <1430203717-13307-1-git-send-email-mlin@kernel.org> <1430203717-13307-2-git-send-email-mlin@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1430203717-13307-2-git-send-email-mlin@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Ming Lin Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Jens Axboe , Kent Overstreet , Dongsu Park , Christoph Hellwig , Al Viro , Ming Lei , Neil Brown , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Lars Ellenberg , drbd-user@lists.linbit.com, Jiri Kosina , Geoff Levand , Jim Paris , Joshua Morris , Philip Kelleher , Minchan Kim , Nitin Gupta , Oleg Drokin , Andreas Dilger , Keith Busch List-Id: dm-devel.ids This seems to lack support for QUEUE_FLAG_SG_GAPS to work around the retarded PPR format in the NVMe driver. I'm actually not sure we have a way to reproduce them for BLOCK_PC requests, but I think we should make sure to properly handle them. Maybe Keith or Jens have a good reproducer for these. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra13.linbit.com (zimbra.linbit.com [212.69.161.123]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTPS id 6FE5710518BC for ; Thu, 7 May 2015 11:35:37 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra13.linbit.com (Postfix) with ESMTP id 5AE52449119 for ; Thu, 7 May 2015 11:35:37 +0200 (CEST) Received: from zimbra13.linbit.com ([127.0.0.1]) by localhost (zimbra13.linbit.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Aptmr_2-5bCp for ; Thu, 7 May 2015 11:35:37 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra13.linbit.com (Postfix) with ESMTP id 3A5D744A5E5 for ; Thu, 7 May 2015 11:35:37 +0200 (CEST) Received: from zimbra13.linbit.com ([127.0.0.1]) by localhost (zimbra13.linbit.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id xdRXmfGEkRD1 for ; Thu, 7 May 2015 11:35:37 +0200 (CEST) Received: from soda.linbit (tuerlsteher.linbit.com [86.59.100.100]) by zimbra13.linbit.com (Postfix) with ESMTPS id 12251449119 for ; Thu, 7 May 2015 11:35:37 +0200 (CEST) Resent-Message-ID: <20150507093536.GQ18767@soda.linbit> Date: Tue, 28 Apr 2015 13:43:20 +0200 From: Christoph Hellwig To: Ming Lin Message-ID: <20150428114320.GA9790@lst.de> References: <1430203717-13307-1-git-send-email-mlin@kernel.org> <1430203717-13307-2-git-send-email-mlin@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430203717-13307-2-git-send-email-mlin@kernel.org> Cc: Mike Snitzer , Neil Brown , Ming Lei , Keith Busch , dm-devel@redhat.com, Joshua Morris , Alasdair Kergon , Lars Ellenberg , Philip Kelleher , Christoph Hellwig , Kent Overstreet , Nitin Gupta , Oleg Drokin , Al Viro , Jens Axboe , Andreas Dilger , Geoff Levand , Jiri Kosina , linux-kernel@vger.kernel.org, Jim Paris , Minchan Kim , Christoph Hellwig , drbd-user@lists.linbit.com Subject: Re: [Drbd-dev] [PATCH 01/10] block: make generic_make_request handle arbitrarily sized bios List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , This seems to lack support for QUEUE_FLAG_SG_GAPS to work around the retarded PPR format in the NVMe driver. I'm actually not sure we have a way to reproduce them for BLOCK_PC requests, but I think we should make sure to properly handle them. Maybe Keith or Jens have a good reproducer for these.