From: "Pali Rohár" <pali.rohar@gmail.com>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Pavel Machek <pavel@ucw.cz>,
Navya Sri Nizamkari <navyasri.tech@gmail.com>,
Luke Hart <luke.hart@birchleys.eu>, Anil Belur <askb23@gmail.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
devel@driverdev.osuosl.org
Subject: Re: [PATCH] radio-bcm2048: remove unused var
Date: Tue, 28 Apr 2015 14:07:56 +0200 [thread overview]
Message-ID: <20150428120756.GE604@pali> (raw)
In-Reply-To: <5784d4a9f48f7661ab1814ef4e8d210fa065bafb.1430222617.git.mchehab@osg.samsung.com>
On Tuesday 28 April 2015 09:03:41 Mauro Carvalho Chehab wrote:
> drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_i2c_driver_probe':
> drivers/staging/media/bcm2048/radio-bcm2048.c:2596:11: warning: variable 'skip_release' set but not used [-Wunused-but-set-variable]
> int err, skip_release = 0;
> ^
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
>
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index e9d0691b21d3..5e11a78ceef3 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -2593,7 +2593,7 @@ static int bcm2048_i2c_driver_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> struct bcm2048_device *bdev;
> - int err, skip_release = 0;
> + int err;
>
> bdev = kzalloc(sizeof(*bdev), GFP_KERNEL);
> if (!bdev) {
> @@ -2646,7 +2646,6 @@ free_sysfs:
> bcm2048_sysfs_unregister_properties(bdev, ARRAY_SIZE(attrs));
> free_registration:
> video_unregister_device(&bdev->videodev);
> - skip_release = 1;
> free_irq:
> if (client->irq)
> free_irq(client->irq, bdev);
Looks good to me, so
Acked-by: Pali Rohár <pali.rohar@gmail.com>
--
Pali Rohár
pali.rohar@gmail.com
prev parent reply other threads:[~2015-04-28 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 12:03 [PATCH] radio-bcm2048: remove unused var Mauro Carvalho Chehab
2015-04-28 12:05 ` Pavel Machek
2015-04-28 12:07 ` Pali Rohár [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150428120756.GE604@pali \
--to=pali.rohar@gmail.com \
--cc=askb23@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hamohammed.sa@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=luke.hart@birchleys.eu \
--cc=mchehab@infradead.org \
--cc=mchehab@osg.samsung.com \
--cc=navyasri.tech@gmail.com \
--cc=pavel@ucw.cz \
--cc=vthakkar1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.