From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031062AbbD1OKW (ORCPT ); Tue, 28 Apr 2015 10:10:22 -0400 Received: from mail-qg0-f54.google.com ([209.85.192.54]:34431 "EHLO mail-qg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030590AbbD1OKT (ORCPT ); Tue, 28 Apr 2015 10:10:19 -0400 Date: Tue, 28 Apr 2015 10:10:14 -0400 From: Tejun Heo To: Petr Mladek Cc: akpm@linux-foundation.org, davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Kay Sievers Subject: Re: [PATCH 04/16] printk: implement support for extended console drivers Message-ID: <20150428141014.GF2152@htj.duckdns.org> References: <1429225433-11946-1-git-send-email-tj@kernel.org> <1429225433-11946-5-git-send-email-tj@kernel.org> <20150420154120.GA4589@pathway.suse.cz> <20150427210922.GA2152@htj.duckdns.org> <20150428094244.GF3979@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150428094244.GF3979@pathway.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Petr. On Tue, Apr 28, 2015 at 11:42:44AM +0200, Petr Mladek wrote: > Note that cont buffer is only a memory optimization. You could put > every text snippet into the ring buffer and console immediately. > You need to set LOG_CONT instead of LOG_NEWLINE flag. This is > already used when the line is too long for the cont buffer or > when there is printed a message from another cpu in the middle > of a continuing message. Yeah, hmmm, I wonder whether the right solution here is to bypass cont buffer if ext_console is present. This would use a bit more memory and hurt users catting /proc/kmsg but everyone else should be able to get the same result and things get a lot simpler on both sending and receiving sides. What do you think? Thanks. -- tejun