From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: Michael Haberler <haberlerm@gmail.com>
Cc: xenomai <xenomai@xenomai.org>
Subject: Re: [Xenomai] RT-CAN driver for C_CAN,D_CAN cores ready
Date: Tue, 28 Apr 2015 18:02:55 +0200 [thread overview]
Message-ID: <20150428160255.GD1993@hermes.click-hack.org> (raw)
In-Reply-To: <CADvZd9azLVdxYd8gy4BwT8Fh1LixV_=vbZoAAZegJ+rAut8mng@mail.gmail.com>
On Tue, Apr 28, 2015 at 05:47:40PM +0200, Michael Haberler wrote:
> as requested:
This is a mess, really, you add files to remove them later.
A patch should be against Xenomai sources, and for adding a driver
it should only add file or modify existing files.
Second point, the indentation, Xenomai follows the linux kernel
rules where the indentation "unit" is a tab characters which should
be displayed as 8 spaces by diff. Here your indentation seems to be
one space (maybe your mailer did that ?).
A smaller patch means an easier review.
--
Gilles.
next prev parent reply other threads:[~2015-04-28 16:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 15:47 [Xenomai] RT-CAN driver for C_CAN,D_CAN cores ready Michael Haberler
2015-04-28 16:02 ` Gilles Chanteperdrix [this message]
2015-04-28 20:19 ` Michael Haberler
2015-04-29 4:30 ` Gilles Chanteperdrix
2015-04-29 7:05 ` Wolfgang Grandegger
-- strict thread matches above, loose matches on Subject: below --
2015-04-19 23:01 Michael Haberler
2015-04-26 20:46 ` Wolfgang Grandegger
2015-04-28 14:01 ` Michael Haberler
2015-04-28 14:11 ` Gilles Chanteperdrix
2015-04-29 6:35 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150428160255.GD1993@hermes.click-hack.org \
--to=gilles.chanteperdrix@xenomai.org \
--cc=haberlerm@gmail.com \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.