From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030852AbbD1SC2 (ORCPT ); Tue, 28 Apr 2015 14:02:28 -0400 Received: from mail-wg0-f54.google.com ([74.125.82.54]:33767 "EHLO mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030572AbbD1SCY (ORCPT ); Tue, 28 Apr 2015 14:02:24 -0400 Date: Tue, 28 Apr 2015 19:02:18 +0100 From: Lee Jones To: Ramakrishna Pallala Cc: linux-kernel@vger.kernel.org, Chanwoo Choi , Samuel Ortiz , Jacob Pan Subject: Re: [PATCH v6] extcon-axp288: Add axp288 extcon driver support Message-ID: <20150428180218.GI9169@x1> References: <1430249879-19429-1-git-send-email-ramakrishna.pallala@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1430249879-19429-1-git-send-email-ramakrishna.pallala@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Apr 2015, Ramakrishna Pallala wrote: > This patch adds the extcon support for AXP288 PMIC which > has the BC1.2 charger detection capability. Additionally > it also adds the USB mux switching support b/w SOC and PMIC > based on GPIO control. > > Signed-off-by: Ramakrishna Pallala > --- > drivers/extcon/Kconfig | 7 + > drivers/extcon/Makefile | 1 + > drivers/extcon/extcon-axp288.c | 399 ++++++++++++++++++++++++++++++++++++++++ > include/linux/mfd/axp20x.h | 9 + > 4 files changed, 416 insertions(+) > create mode 100644 drivers/extcon/extcon-axp288.c [...] > diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h > index dfabd6d..38653e0 100644 > --- a/include/linux/mfd/axp20x.h > +++ b/include/linux/mfd/axp20x.h > @@ -275,4 +275,13 @@ struct axp20x_fg_pdata { > int thermistor_curve[MAX_THERM_CURVE_SIZE][2]; > }; > > +#define AXP288_EXTCON_SLOW_CHARGER "SLOW-CHARGER" > +#define AXP288_EXTCON_DOWNSTREAM_CHARGER "CHARGE-DOWNSTREAM" > +#define AXP288_EXTCON_FAST_CHARGER "FAST-CHARGER" > + > +struct axp288_extcon_pdata { > + /* GPIO pin control to switch D+/D- lines b/w PMIC and SOC */ > + struct gpio_desc *gpio_mux_cntl; > +}; > + > #endif /* __LINUX_MFD_AXP20X_H */ Not sure what you decided since sending this, but in order for me to avoid becoming the bottle-neck: Acked-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog