Re: [Qemu-devel] [PATCH qemu v2] qemu-options: Add documentation about PPC64's "-cpu compat" option

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]

On Tue, Apr 28, 2015 at 05:25:37PM +1000, Alexey Kardashevskiy wrote:
> On 04/10/2015 12:16 PM, David Gibson wrote:
> >On Wed, Apr 08, 2015 at 07:33:21PM +1000, Alexey Kardashevskiy wrote:
> >>Since 8dfa3a5e "target-ppc: Add "compat" CPU option" (which was a part of
> >>client-architecture-support patchset) there is a "compat" option
> >>of "-cpu". However it was not documented at all and this is what this
> >>patch is trying to do.
> >>
> >>Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> >
> >I've updated the previous version in spapr-next.
> 
> That was bad idea.
> 
> First of all this patch is missing this:
> 
> diff --git a/vl.c b/vl.c
> index 694deb4..12ffa1c 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2876,6 +2876,7 @@ int main(int argc, char **argv, char **envp)
>                  break;
>              }
>              case QEMU_OPTION_cpu:
> +            case QEMU_OPTION_cpu_ppc:
>                  /* hw initialization will check this */
>                  cpu_model = optarg;
>                  break;
> 
> 
> But even with it, "-cpu help" does not work as the "if (!(popt->arch_mask &
> arch_type))" fails at vl.c:2868 because QEMU_OPTION_cpu does not have
> PPC64bit set (in order to hide unwanted options on x86) and
> QEMU_OPTION_cpu_ppc is not "-cpu".
> 
> We should use the original patch or none at all.

Ok, I've dropped this from spapr-next for the time being.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]