From: Marcelo Tosatti <mtosatti@redhat.com>
To: kvm@vger.kernel.org
Cc: Andy Lutomirski <luto@amacapital.net>, Rik van Riel <riel@redhat.com>
Subject: Re: x86: kvmclock: drop rdtsc_barrier()
Date: Tue, 28 Apr 2015 22:47:38 -0300 [thread overview]
Message-ID: <20150429014737.GA14997@amt.cnet> (raw)
In-Reply-To: <20150425013614.GA12023@amt.cnet>
On Fri, Apr 24, 2015 at 10:36:14PM -0300, Marcelo Tosatti wrote:
>
> Drop unnecessary rdtsc_barrier(), as has been determined empirically,
> see 057e6a8c660e95c3f4e7162e00e2fee1fc90c50d for details.
>
> Noticed by Andy Lutomirski.
>
> Improves clock_gettime() by approximately 15% on
> Intel i7-3520M @ 2.90GHz.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> diff --git a/arch/x86/include/asm/pvclock.h b/arch/x86/include/asm/pvclock.h
> index 25b1cc0..a5beb23 100644
> --- a/arch/x86/include/asm/pvclock.h
> +++ b/arch/x86/include/asm/pvclock.h
> @@ -86,7 +86,6 @@ unsigned __pvclock_read_cycles(const struct pvclock_vcpu_time_info *src,
> offset = pvclock_get_nsec_offset(src);
> ret = src->system_time + offset;
> ret_flags = src->flags;
> - rdtsc_barrier();
>
> *cycles = ret;
> *flags = ret_flags;
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Ping?
prev parent reply other threads:[~2015-04-29 1:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-25 1:36 x86: kvmclock: drop rdtsc_barrier() Marcelo Tosatti
2015-04-25 1:45 ` Rik van Riel
2015-04-29 1:47 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429014737.GA14997@amt.cnet \
--to=mtosatti@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.