From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1031544AbbD2IGb (ORCPT <rfc822;w@1wt.eu>);
	Wed, 29 Apr 2015 04:06:31 -0400
Received: from mga02.intel.com ([134.134.136.20]:46931 "EHLO mga02.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1031401AbbD2IGZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 29 Apr 2015 04:06:25 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,669,1422950400"; 
   d="scan'208";a="687304589"
Date: Wed, 29 Apr 2015 11:04:12 +0300
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Felipe Balbi <balbi@ti.com>
Cc: David Cohen <david.a.cohen@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Baolu Lu <baolu.lu@linux.intel.com>, Paul Bolle <pebolle@tiscali.nl>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 08/11] usb: dwc3: add hsphy_interface property
Message-ID: <20150429080412.GA25288@kuha.fi.intel.com>
References: <1430227486-225197-1-git-send-email-heikki.krogerus@linux.intel.com>
 <1430227486-225197-9-git-send-email-heikki.krogerus@linux.intel.com>
 <20150428171326.GM18263@saruman.tx.rr.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150428171326.GM18263@saruman.tx.rr.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +	/* Select the HS PHY interface */
> > +	switch (DWC3_GHWPARAMS3_HSPHY_IFC(dwc->hwparams.hwparams3)) {
> > +	case DWC3_GHWPARAMS3_HSPHY_IFC_UTMI_ULPI:
> > +		if (!strncmp(dwc->hsphy_interface, "utmi", 4)) {
> > +			reg &= ~DWC3_GUSB2PHYCFG_ULPI_UTMI;
> > +		} else if (!strncmp(dwc->hsphy_interface, "ulpi", 4)) {
> > +			reg |= DWC3_GUSB2PHYCFG_ULPI_UTMI;
> > +		} else {
> > +			dev_err(dwc->dev, "HSPHY Interface not defined\n");
> > +			return -EINVAL;
> 
> instead of erroring out, just leave default value and convert this to a
> dev_warn() or something similar. That way, older DTS will continue to
> work.

OK, I'll change it.

Thanks,

-- 
heikki