Re: [alsa-devel] [PATCH v2 2/2] mfd: arizona: Update DT binding to support hpdet channel

[Lee Jones <lee.jones@linaro.org>]

Does this looks okay to you Charles?

> This patch add device tree bindings for the pdata needed to configure
> the Accessory Detect Mode select when Headphone detection.

Isn't the idea of headphone detection that it headphones are detected
i.e. automatically?

> Signed-off-by: Inha Song <ideal.song@samsung.com>
> ---
>  Documentation/devicetree/bindings/mfd/arizona.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index 7bd1273..3529592 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -49,6 +49,12 @@ Optional properties:
>      input singals. If values less than the number of input signals, elements
>      that has not been specifed are set to 0 by default.
>  
> +  - wlf,hpdet-channel : Headphone detection channel.
> +	1 or ARIZONA_ACCDET_MODE_HPL - Headphone detect mode is set to HPDETL
> +	2 or ARIZONA_ACCDET_MODE_HPR - Headphone detect mode is set to HPDETR
> +	If this node is not mentioned or if the value is unknown, then
> +	headphone detection mode is set to MICDET.
> +
>    - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
>      they are being externally supplied. As covered in
>      Documentation/devicetree/bindings/regulator/regulator.txt

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog