From: David Weinehall <david.weinehall@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
"Antoine, Peter" <peter.antoine@intel.com>,
Deepak S <deepak.s@linux.intel.com>,
"S, Deepak" <deepak.s@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Tian, YeX" <yex.tian@intel.com>
Subject: Re: [PATCH v2] drm/i915: Avoid GPU hang when coming out of S3 or S4
Date: Wed, 29 Apr 2015 14:07:19 +0300 [thread overview]
Message-ID: <20150429110719.GA31734@boom> (raw)
In-Reply-To: <20150428144646.GG599@nuc-i3427.alporthouse.com>
On Tue, Apr 28, 2015 at 03:46:46PM +0100, Chris Wilson wrote:
> On Tue, Apr 28, 2015 at 02:38:25PM +0000, Antoine, Peter wrote:
> > So is the plan to push these patches and have follow-on work to cover the other paths?
> > As this fixes the Bugzilla issue that has been raised.
>
> You've identified an issue, but I think your patch is incomplete.
I've tried my best to go through the remaining similar-looking code,
but the rest seems fine (I might've missed something though).
The only thing I reacted on was that in intel_runtime_resume() the call
to intel_init_pch_refclk() is conditional on IS_GEN6(), but none of the
other invocations of intel_init_pch_refclk() are. The commit message
doesn't seem to provide a sufficient explanation for why this is so.
Regards, David
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-04-29 11:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 14:25 [PATCH] drm/i915: Avoid GPU hang when coming out of P3 or P4 Peter Antoine
2015-04-27 14:31 ` Antoine, Peter
2015-04-27 14:33 ` Chris Wilson
2015-04-28 7:18 ` [PATCH v2] drm/i915: Avoid GPU hang when coming out of S3 or S4 Peter Antoine
2015-04-28 7:23 ` Chris Wilson
2015-04-28 8:29 ` S, Deepak
2015-04-28 8:44 ` Chris Wilson
2015-04-28 8:55 ` Deepak S
2015-04-28 14:38 ` Antoine, Peter
2015-04-28 14:46 ` Chris Wilson
2015-04-29 11:07 ` David Weinehall [this message]
2015-04-29 11:39 ` Chris Wilson
2015-05-04 14:55 ` Daniel Vetter
2015-05-05 7:05 ` Antoine, Peter
2015-05-05 7:06 ` Antoine, Peter
2015-05-05 7:43 ` S, Deepak
2015-04-28 9:28 ` shuang.he
2015-04-28 9:31 ` [PATCH] drm/i915: Avoid GPU hang when coming out of P3 or P4 shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429110719.GA31734@boom \
--to=david.weinehall@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=deepak.s@intel.com \
--cc=deepak.s@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=peter.antoine@intel.com \
--cc=yex.tian@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.