From: Christoph Hellwig <hch@lst.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: dm-devel@redhat.com, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] dm: fix blk-mq request-based DM queue initialization
Date: Wed, 29 Apr 2015 15:00:37 +0200 [thread overview]
Message-ID: <20150429130037.GA3017@lst.de> (raw)
In-Reply-To: <1430269153-647-1-git-send-email-snitzer@redhat.com>
On Tue, Apr 28, 2015 at 08:59:13PM -0400, Mike Snitzer wrote:
> Commit bfebd1cdb4 ("dm: add full blk-mq support to request-based DM")
> didn't properly account for the need to short-circuit re-initializing
> DM's blk-mq request_queue if it was already initialized.
>
> Fix dm_init_request_based_blk_mq_queue() to return early if the
> mapped_device's tag_set already has its driver_data set to the
> mapped_device pointer.
I'm not quite up to speed with this area of code, but shouldn't
we always tear the queue fully down before trying to reinitialize it?
next prev parent reply other threads:[~2015-04-29 13:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-25 9:23 CONFIG_DM_MQ_DEFAULT makes my kernel unhappy Christoph Hellwig
2015-04-25 15:28 ` Mike Snitzer
2015-04-25 15:37 ` Christoph Hellwig
2015-04-26 14:16 ` Christoph Hellwig
2015-04-27 15:59 ` Mike Snitzer
2015-04-27 16:03 ` Christoph Hellwig
2015-04-27 19:03 ` Mike Snitzer
2015-04-29 0:59 ` [PATCH] dm: fix blk-mq request-based DM queue initialization Mike Snitzer
2015-04-29 13:00 ` Christoph Hellwig [this message]
2015-04-30 1:41 ` Mike Snitzer
2015-04-30 7:22 ` Christoph Hellwig
2015-04-30 8:23 ` Christoph Hellwig
2015-04-30 12:47 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429130037.GA3017@lst.de \
--to=hch@lst.de \
--cc=dm-devel@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.