From: Christoph Hellwig <hch@lst.de>
To: NeilBrown <neilb@suse.de>
Cc: Mike Snitzer <snitzer@redhat.com>, Jens Axboe <axboe@fb.com>,
Azat Khuzhin <a3at.mail@gmail.com>,
Christoph Hellwig <hch@lst.de>,
"Kernel.org-Linux-RAID" <linux-raid@vger.kernel.org>,
Guoqing Jiang <GQJiang@suse.com>, Tejun Heo <tj@kernel.org>,
Jan Kara <jack@suse.cz>, lkml <linux-kernel@vger.kernel.org>,
device-mapper development <dm-devel@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH -stable] block: destroy bdi before blockdev is unregistered.
Date: Wed, 29 Apr 2015 15:35:12 +0200 [thread overview]
Message-ID: <20150429133512.GA4436@lst.de> (raw)
In-Reply-To: <20150429072530.39d38b00@notabene.brown>
On Wed, Apr 29, 2015 at 07:25:30AM +1000, NeilBrown wrote:
> As bdi_set_min_ratio doesn't touch bdi->dev, there seems to be no need for
> the test, or the warning.
>
> I wonder if it would make sense to move the bdi_set_min_ratio() call to
> bdi_destroy, and discard bdi_unregister??
> There is a comment which suggests bdi_unregister might be of use later, but
> it might be best to have a clean slate in which to add whatever might be
> needed??
This seems fine to me from the block dev point of view. I don't really
understand the bdi_min_ratio logic, but Peter might have a better idea.
next prev parent reply other threads:[~2015-04-29 13:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 17:15 BUG: unable to handle kernel NULL pointer dereference at sysfs_do_create_link_sd (after mdadm) Azat Khuzhin
2015-04-15 2:44 ` Guoqing Jiang
2015-04-15 8:47 ` Azat Khuzhin
2015-04-23 6:05 ` Bisected, with rfc/patch - was " NeilBrown
2015-04-23 7:37 ` Christoph Hellwig
2015-04-23 8:03 ` NeilBrown
2015-04-23 16:10 ` Christoph Hellwig
2015-04-24 2:09 ` NeilBrown
2015-04-24 8:27 ` Christoph Hellwig
2015-04-27 4:12 ` [PATCH -stable] block: destroy bdi before blockdev is unregistered NeilBrown
2015-04-27 13:03 ` Christoph Hellwig
2015-04-27 16:27 ` Jens Axboe
2015-04-28 16:41 ` Mike Snitzer
2015-04-28 21:25 ` NeilBrown
2015-04-29 13:35 ` Christoph Hellwig [this message]
2015-04-29 16:02 ` Peter Zijlstra
2015-04-30 0:06 ` NeilBrown
2015-04-30 0:32 ` [PATCH stable] block: discard bdi_unregister() in favour of bdi_destroy() NeilBrown
2015-04-30 8:35 ` Peter Zijlstra
2015-05-06 16:11 ` [dm-devel] " Dan Williams
2015-05-08 5:09 ` [PATCH v2] " NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429133512.GA4436@lst.de \
--to=hch@lst.de \
--cc=GQJiang@suse.com \
--cc=a3at.mail@gmail.com \
--cc=axboe@fb.com \
--cc=dm-devel@redhat.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=peterz@infradead.org \
--cc=snitzer@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.