From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnTmh-0006oX-B9 for qemu-devel@nongnu.org; Wed, 29 Apr 2015 11:20:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnTmd-0002iG-BY for qemu-devel@nongnu.org; Wed, 29 Apr 2015 11:20:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnTmd-0002i6-6W for qemu-devel@nongnu.org; Wed, 29 Apr 2015 11:20:19 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id BD2BCC12FF for ; Wed, 29 Apr 2015 15:20:18 +0000 (UTC) Date: Wed, 29 Apr 2015 17:20:16 +0200 From: Kashyap Chamarthy Message-ID: <20150429152016.GE2764@tesla.redhat.com> References: <1429799701-27089-1-git-send-email-jsnow@redhat.com> <20150423162331.GE10067@tesla.redhat.com> <20150428161732.GD11726@tesla.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150428161732.GD11726@tesla.redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 0/4] scripts: qmp-shell: add transaction support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com On Tue, Apr 28, 2015 at 06:17:32PM +0200, Kashyap Chamarthy wrote: [. . .] > > Seems like a regression from your v2. > > > > It fails here, even for a non-transaction command, with your patch series > > applied: > > > > (QEMU) blockdev-snapshot-internal-sync device=drive-ide0-0-0 name=snapshot0 > > Error while parsing command line: global name '_QMPShell__parse_value' is not defined > > command format: [arg-name1=arg1] ... [arg-nameN=argN] > > I now tested again with your qmp-shell-plus branch: > > $ git describe > v2.3.0-rc4-4-g994af97 > > $ git log --oneline | head -4 > 994af97 scripts: qmp-shell: Add verbose flag > 1009369 scripts: qmp-shell: add transaction subshell > 0ae65ff scripts: qmp-shell: Expand support for QMP expressions > 5f367d9 scripts: qmp-shell: refactor helpers > > Result: > > - The non-transaction commands work just fine; so that regression is > fixed in your qmp-shell-plus branch. > - The transaction command (same commands as tested previously, > retained it below) still fails. Tested with your newer branch[1], this time, good news -- from my minimal testing, no regressions found while running transactional/ non-transactional commands. As a transactional subshell test, I ran a three-combination command like below: (QEMU) transaction( TRANS> blockdev-snapshot-sync device=drive-ide0-0-0 snapshot-file=./ext-snap2.qcow2 format=qcow2 TRANS> blockdev-snapshot-internal-sync device=drive-ide0-0-0 name=snapshot1 TRANS> drive-backup device=drive-ide0-0-0 sync=full target=./backup-copy.qcow2 mode=absolute-paths format=qcow2 TRANS> ) {"return": {}} (QEMU) When you submit a new version to the list, FWIW, you can carry my 'Tested-by'. [1] https://github.com/jnsnow/qemu/tree/qmp-shell%2B%2B -- /kashyap