From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58059)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YnWn5-0000k5-Qk
	for qemu-devel@nongnu.org; Wed, 29 Apr 2015 14:33:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YnWn1-0006uF-Nl
	for qemu-devel@nongnu.org; Wed, 29 Apr 2015 14:32:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55817)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YnWn1-0006u9-IU
	for qemu-devel@nongnu.org; Wed, 29 Apr 2015 14:32:55 -0400
Date: Wed, 29 Apr 2015 20:32:50 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150429203237-mutt-send-email-mst@redhat.com>
References: <20150428151249-mutt-send-email-mst@redhat.com>
	<CAFEAcA8Ch9iCfTmudGS+BmxghNxSE4CvBdy0q4bZOEsUyMC8CA@mail.gmail.com>
	<20150428152419.67bc77b1.cornelia.huck@de.ibm.com>
	<20150428160354-mutt-send-email-mst@redhat.com>
	<20150428201255-mutt-send-email-mst@redhat.com>
	<20150428203016-mutt-send-email-mst@redhat.com>
	<554093B3.2080205@de.ibm.com>
	<20150429105215.0a1122f2.cornelia.huck@de.ibm.com>
	<20150429103204.GA12976@redhat.com>
	<20150429163344.5ecfcea8.cornelia.huck@de.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150429163344.5ecfcea8.cornelia.huck@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to
 backends
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, hangaohuai@huawei.com, QEMU Developers <qemu-devel@nongnu.org>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Shannon Zhao <shannon.zhao@linaro.org>, Shannon Zhao <zhaoshenglong@huawei.com>, Paolo Bonzini <pbonzini@redhat.com>, Christoffer Dall <christoffer.dall@linaro.org>

On Wed, Apr 29, 2015 at 04:33:44PM +0200, Cornelia Huck wrote:
> On Wed, 29 Apr 2015 12:32:04 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> > On Wed, Apr 29, 2015 at 10:52:15AM +0200, Cornelia Huck wrote:
> 
> > > And (surprise, surprise) virtio-blk now works - but it also works when
> > > I back out the atomic.h change again. No barrier problems :)
> > > 
> > > Good news is that we can change s390-virtio to be just like the other
> > > transports. Although I'd like to understand why it was broken before.
> > > Maybe a guest change?
> > 
> > Or a compiler change? Try compiling some old release, see what happens.
> 
> Nope, same compiler as back then (old setup). My current guess is some
> change in other code.

bisect is you friend then :)

> > Anyway, let's move DEFINE_VIRTIO_COMMON_FEATURES into the base class
> > now.  Can you send a patch pls?
> 
> I think virtio-blk-s390 not working anymore will be easy to catch (it
> is used in some of the iotests). I'll move the features.