All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>,
	Stephane Eranian <eranian@google.com>,
	Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] perf report: Fix -T/--threads option to work again
Date: Wed, 29 Apr 2015 18:36:58 -0300	[thread overview]
Message-ID: <20150429213658.GA29633@kernel.org> (raw)
In-Reply-To: <1430309328-28317-1-git-send-email-namhyung@kernel.org>

Em Wed, Apr 29, 2015 at 09:08:48PM +0900, Namhyung Kim escreveu:
> The commit 512ae1bd6acb ("perf tools: Consolidate management of default
> sort orders") changed default value of the 'sort_order' variable to NULL
> indicating that users don't set any sort keys on the command line.
> 
> However it missed to update a check in perf_evlist__tty_browse_hists()
> so that 'perf report -T' cannot show the per-thread values after the
> normal output.  This patch fixes it to work again.
> 
> Note that the -T option only works on --stdio and neither --sort nor
> --parent option was given.

Thanks, applied to perf/urgent.

- Arnaldo

  reply	other threads:[~2015-05-04 20:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-29 12:08 [PATCH] perf report: Fix -T/--threads option to work again Namhyung Kim
2015-04-29 21:36 ` Arnaldo Carvalho de Melo [this message]
2015-05-06  4:36 ` [tip:perf/urgent] perf report: Fix -T/ --threads " tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150429213658.GA29633@kernel.org \
    --to=acme@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=andi@firstfloor.org \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.