From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751040AbbD3KhR (ORCPT ); Thu, 30 Apr 2015 06:37:17 -0400 Received: from mga03.intel.com ([134.134.136.65]:47246 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbbD3KhP (ORCPT ); Thu, 30 Apr 2015 06:37:15 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,676,1422950400"; d="scan'208";a="718356825" Date: Thu, 30 Apr 2015 13:37:11 +0300 From: Heikki Krogerus To: Felipe Balbi Cc: David Cohen , Greg Kroah-Hartman , Stephen Boyd , Baolu Lu , Paul Bolle , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3 01/11] usb: add bus type for USB ULPI Message-ID: <20150430103711.GC1372@kuha.fi.intel.com> References: <1430227486-225197-1-git-send-email-heikki.krogerus@linux.intel.com> <1430227486-225197-2-git-send-email-heikki.krogerus@linux.intel.com> <20150429201325.GB5008@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150429201325.GB5008@saruman.tx.rr.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > +struct bus_type ulpi_bus = { > > non-static and undeclared anywhere, adds a sparse error. I'm dropping > the series for now :-) > > " > drivers/usb/common/ulpi.c:77:17: warning: symbol 'ulpi_bus' was not > declared. Should it be static? > " Need to fix that. I'll wait for your comment's to 10/12 before preparing new version. Thanks, -- heikki