Re: [PATCH v3 4/7] ASoC: intel - add Skylake HDA platform driver

[Vinod Koul <vinod.koul@intel.com>]

On Thu, Apr 30, 2015 at 11:52:47AM +0200, Takashi Iwai wrote:
> > > > +	},
> > > > +},
> > > > +{
> > > > +	.name = "Deepbuffer Pin",
> > > > +	.ops = &hda_pcm_dai_ops,
> > > > +	.playback = {
> > > > +		.stream_name = "Deepbuffer Playback",
> > > > +		.channels_min = HDA_STEREO,
> > > > +		.channels_max = HDA_STEREO,
> > > > +		.rates = SNDRV_PCM_RATE_48000,
> > > > +		.formats = SNDRV_PCM_FMTBIT_S16_LE,
> > > > +	},
> > > > +},
> > > > +{
> > > > +	.name = "LowLatency Pin",
> > > > +	.ops = &hda_pcm_dai_ops,
> > > > +	.playback = {
> > > > +		.stream_name = "Low Latency Playback",
> > > > +		.channels_min = HDA_STEREO,
> > > > +		.channels_max = HDA_STEREO,
> > > > +		.rates = SNDRV_PCM_RATE_48000,
> > > > +		.formats = SNDRV_PCM_FMTBIT_S16_LE,
> > > > +	},
> > > 
> > > Are there no S32_LE support at all for all dais?
> > No, just 16 and 24 bits :)
> 
> Hm, so this restriction remains also for decoupled from DSP?
Yes it is the DSP which is adding this restriction, we do render at 16 and
24 bits only

> All HDA codecs supports 24bit formats (in S32_LE form), but in your
> patch, 24bit format is supported only for System Capture.
This is platform params, the codec support will be in DAI params for the
codec

-- 
~Vinod