From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Edgar E. Iglesias" Subject: Re: [PATCH v2 2/3] xen/arm: Add p2m_pfn_bits Date: Thu, 30 Apr 2015 21:48:29 +1000 Message-ID: <20150430114829.GA4702@toto> References: <1430374003-22789-1-git-send-email-edgar.iglesias@gmail.com> <1430374003-22789-3-git-send-email-edgar.iglesias@gmail.com> <5541F847.7070204@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5541F847.7070204@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: edgar.iglesias@xilinx.com, stefano.stabellini@citrix.com, tim@xen.org, ian.campbell@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, Apr 30, 2015 at 10:39:19AM +0100, Julien Grall wrote: > Hi Edgar, > > On 30/04/2015 07:06, Edgar E. Iglesias wrote: > > val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ > > val |= VTCR_SL0(0x1); /* P2M starts at first level */ > > #else /* CONFIG_ARM_64 */ > >@@ -1557,6 +1561,7 @@ void __init setup_virt_paging(void) > > > > p2m_root_order = pa_range_info[pa_range].root_order; > > p2m_root_level = 2 - pa_range_info[pa_range].sl0; > >+ p2m_pfn_bits = 64 - pa_range_info[pa_range].t0sz; > > You are mixing IPA (Intermediate Physical Address) and PFN (Page > Frame Number) which have to 2 distinct meaning. > > In this case, we are dealing with IPA. Please rename the variable to > p2m_ipa_bits and replace PFN by IPA in all the patch. Oops, yes I'll fix that up and send a new version. Thanks, Edgar