From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 30 Apr 2015 14:47:13 +0000 Subject: Re: [patch] drm/i915: checking IS_ERR() instead of NULL Message-Id: <20150430144713.GD16501@mwanda> List-Id: References: <20150430143050.GB22086@mwanda> <20150430144302.GB31838@nuc-i3427.alporthouse.com> In-Reply-To: <20150430144302.GB31838@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Chris Wilson , Daniel Vetter , Jani Nikula , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org On Thu, Apr 30, 2015 at 03:43:02PM +0100, Chris Wilson wrote: > On Thu, Apr 30, 2015 at 05:30:50PM +0300, Dan Carpenter wrote: > > We switched from calling i915_gem_alloc_context_obj() to calling > > i915_gem_alloc_object() so the error handling needs to be updated to > > check for NULL instead of IS_ERR(). > > I had a patch to change i915_gem_alloc_object() to report the correct > error rather than NULL - which can come in surprisingly handy at > times... That also works, of course. Send it. :) regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [patch] drm/i915: checking IS_ERR() instead of NULL Date: Thu, 30 Apr 2015 17:47:13 +0300 Message-ID: <20150430144713.GD16501@mwanda> References: <20150430143050.GB22086@mwanda> <20150430144302.GB31838@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20150430144302.GB31838@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson , Daniel Vetter , Jani Nikula , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBBcHIgMzAsIDIwMTUgYXQgMDM6NDM6MDJQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIFRodSwgQXByIDMwLCAyMDE1IGF0IDA1OjMwOjUwUE0gKzAzMDAsIERhbiBDYXJw ZW50ZXIgd3JvdGU6Cj4gPiBXZSBzd2l0Y2hlZCBmcm9tIGNhbGxpbmcgaTkxNV9nZW1fYWxsb2Nf Y29udGV4dF9vYmooKSB0byBjYWxsaW5nCj4gPiBpOTE1X2dlbV9hbGxvY19vYmplY3QoKSBzbyB0 aGUgZXJyb3IgaGFuZGxpbmcgbmVlZHMgdG8gYmUgdXBkYXRlZCB0bwo+ID4gY2hlY2sgZm9yIE5V TEwgaW5zdGVhZCBvZiBJU19FUlIoKS4KPiAKPiBJIGhhZCBhIHBhdGNoIHRvIGNoYW5nZSBpOTE1 X2dlbV9hbGxvY19vYmplY3QoKSB0byByZXBvcnQgdGhlIGNvcnJlY3QKPiBlcnJvciByYXRoZXIg dGhhbiBOVUxMIC0gd2hpY2ggY2FuIGNvbWUgaW4gc3VycHJpc2luZ2x5IGhhbmR5IGF0Cj4gdGlt ZXMuLi4KClRoYXQgYWxzbyB3b3Jrcywgb2YgY291cnNlLiAgU2VuZCBpdC4gIDopCgpyZWdhcmRz LApkYW4gY2FycGVudGVyCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo=