From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: linux-leds@vger.kernel.org, linux-media@vger.kernel.org,
kyungmin.park@samsung.com, cooloney@gmail.com, rpurdie@rpsys.net,
sakari.ailus@iki.fi, s.nawrocki@samsung.com
Subject: Re: [PATCH v6 05/10] leds: Add driver for AAT1290 flash LED controller
Date: Thu, 30 Apr 2015 19:47:24 +0200 [thread overview]
Message-ID: <20150430174724.GD23579@amd> (raw)
In-Reply-To: <1430205530-20873-6-git-send-email-j.anaszewski@samsung.com>
> +struct aat1290_led_config_data {
> + /* maximum LED current in movie mode */
> + u32 max_mm_current;
> + /* maximum LED current in flash mode */
> + u32 max_flash_current;
> + /* maximum flash timeout */
> + u32 max_flash_tm;
Ok, the comments tell us what should be already obvious from the
variable names... but it would be nice to add units. (mA? uA? msec?)
(I guess in subsequent patch).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-04-30 17:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 7:18 [PATCH v6 00/10] LED / flash API integration Jacek Anaszewski
2015-04-28 7:18 ` [PATCH v6 01/10] leds: unify the location of led-trigger API Jacek Anaszewski
2015-04-29 0:20 ` Bryan Wu
2015-04-29 0:20 ` Bryan Wu
2015-04-28 7:18 ` [PATCH v6 02/10] DT: Add documentation for the mfd Maxim max77693 Jacek Anaszewski
[not found] ` <1430205530-20873-3-git-send-email-j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-04-28 10:09 ` Lee Jones
2015-04-28 10:09 ` Lee Jones
2015-04-29 0:24 ` Bryan Wu
2015-04-29 8:25 ` Lee Jones
2015-04-28 7:18 ` [PATCH v6 03/10] leds: Add support for max77693 mfd flash cell Jacek Anaszewski
2015-04-28 11:36 ` Sakari Ailus
2015-04-29 0:28 ` Bryan Wu
2015-04-28 7:18 ` [PATCH v6 04/10] DT: Add documentation for the Skyworks AAT1290 Jacek Anaszewski
2015-04-29 0:29 ` Bryan Wu
2015-04-28 7:18 ` [PATCH v6 05/10] leds: Add driver for AAT1290 flash LED controller Jacek Anaszewski
2015-04-28 11:36 ` Sakari Ailus
2015-04-29 0:32 ` Bryan Wu
2015-04-30 17:47 ` Pavel Machek [this message]
2015-04-28 7:18 ` [PATCH v6 06/10] media: Add registration helpers for V4L2 flash sub-devices Jacek Anaszewski
2015-04-28 12:01 ` Sakari Ailus
2015-04-28 7:18 ` [PATCH v6 07/10] Documentation: leds: Add description of v4l2-flash sub-device Jacek Anaszewski
2015-04-28 12:05 ` Sakari Ailus
2015-04-28 7:18 ` [PATCH v6 08/10] leds: max77693: add support for V4L2 Flash sub-device Jacek Anaszewski
2015-04-28 12:11 ` Sakari Ailus
2015-04-28 7:18 ` [PATCH v6 09/10] DT: aat1290: Document handling external strobe sources Jacek Anaszewski
2015-04-28 7:18 ` [PATCH v6 10/10] leds: aat1290: add support for V4L2 Flash sub-device Jacek Anaszewski
2015-04-28 14:02 ` Sakari Ailus
2015-04-28 14:56 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150430174724.GD23579@amd \
--to=pavel@ucw.cz \
--cc=cooloney@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.