From: Borislav Petkov <bp@suse.de>
To: "Luis R. Rodriguez" <mcgrof@suse.com>
Cc: Kyle McMartin <kyle@kernel.org>, Christoph Lameter <cl@linux.com>,
Alok N Kataria <alokk@calsoftinc.com>,
Shobhit Dayal <shobhit@calsoftinc.com>,
Shai Fultheim <shai@scalex86.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
mingo@elte.hu, tglx@linutronix.de, hpa@zytor.com,
plagnioj@jcrosoft.com, tomi.valkeinen@ti.com,
daniel.vetter@intel.com, airlied@linux.ie, dledford@redhat.com,
awalls@md.metrocast.net, syrjala@sci.fi, luto@amacapital.net,
mst@redhat.com, cocci@systeme.lip6.fr,
linux-kernel@vger.kernel.org, Juergen Gross <jgross@suse.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Dave Airlie <airlied@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
x86@kernel.org
Subject: Re: [PATCH v4 2/8] init.h: add __read_mostly to early_param_on_off()
Date: Thu, 30 Apr 2015 20:42:32 +0200 [thread overview]
Message-ID: <20150430184232.GG5117@pd.tnic> (raw)
In-Reply-To: <20150430183200.GW5622@wotan.suse.de>
On Thu, Apr 30, 2015 at 08:32:00PM +0200, Luis R. Rodriguez wrote:
> In this particular case early_param_on_off() will be used for boot
> time kernel parameters which we do not intend on dynamically change a
> lot at run time, we
It is not about whether you're going to dynamically change it but more
about how often it is accessed. If it is accessed only a couple of times
tops during boot and then never again during the system lifetime - which
is generally the case for most boot params - then you certainly don't
want to pollute the read.mostly section with dead weight. You can just
as well use a stinking normal variable.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-04-30 18:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 21:44 [PATCH v4 0/8] x86: address drivers that do not work with PAT Luis R. Rodriguez
2015-04-29 21:44 ` [PATCH v4 1/8] x86/mm/pat: use pr_info() and friends Luis R. Rodriguez
2015-04-30 13:56 ` Borislav Petkov
2015-04-30 18:15 ` Luis R. Rodriguez
2015-04-29 21:44 ` [PATCH v4 2/8] init.h: add __read_mostly to early_param_on_off() Luis R. Rodriguez
2015-04-30 16:00 ` Borislav Petkov
2015-04-30 18:32 ` Luis R. Rodriguez
2015-04-30 18:34 ` Luis R. Rodriguez
2015-04-30 18:42 ` Borislav Petkov [this message]
2015-04-30 18:46 ` Christoph Lameter
2015-04-29 21:44 ` [PATCH v4 3/8] init.h: add early_param_on() and early_param_off() Luis R. Rodriguez
2015-04-29 21:44 ` [PATCH v4 4/8] x86/mm/pat: use early_param_off() and redefine pat_enabled() Luis R. Rodriguez
2015-04-29 21:44 ` [PATCH v4 5/8] arch/x86/mm/pat: export pat_enabled() Luis R. Rodriguez
2015-04-29 21:44 ` [PATCH v4 6/8] ivtv: use arch_phys_wc_add() and require PAT disabled Luis R. Rodriguez
2015-04-29 21:44 ` Luis R. Rodriguez
2015-04-29 21:44 ` Luis R. Rodriguez
[not found] ` <1430343867-1001-1-git-send-email-mcgrof-3uybbJdB1yH774rrrx3eTA@public.gmane.org>
2015-04-29 21:44 ` [PATCH v4 7/8] IB/ipath: add counting for MTRR Luis R. Rodriguez
2015-04-29 21:44 ` Luis R. Rodriguez
2015-04-29 21:44 ` Luis R. Rodriguez
2015-04-29 21:44 ` [PATCH v4 8/8] IB/ipath: use arch_phys_wc_add() and require PAT disabled Luis R. Rodriguez
2015-04-29 21:44 ` Luis R. Rodriguez
2015-04-29 21:44 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150430184232.GG5117@pd.tnic \
--to=bp@suse.de \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alokk@calsoftinc.com \
--cc=awalls@md.metrocast.net \
--cc=bhelgaas@google.com \
--cc=cl@linux.com \
--cc=cocci@systeme.lip6.fr \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dledford@redhat.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kyle@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=plagnioj@jcrosoft.com \
--cc=shai@scalex86.org \
--cc=shobhit@calsoftinc.com \
--cc=syrjala@sci.fi \
--cc=tglx@linutronix.de \
--cc=tomi.valkeinen@ti.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.