All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Bisson <gary.bisson@boundarydevices.com>
To: buildroot@busybox.net
Subject: [Buildroot] [v7, 02/13] gpu-viv-bin-mx6q: fix compiling issues with EGL_API_FB
Date: Thu, 30 Apr 2015 20:57:16 +0200	[thread overview]
Message-ID: <20150430185716.GA8609@t450s.lan> (raw)
In-Reply-To: <1430406748-8493-3-git-send-email-jezz@sysmic.org>

Hi Jerome,

On Thu, Apr 30, 2015 at 05:12:17PM +0200, J?r?me Pouiller wrote:
> To compile with Vivante header and use framebuffer, it is necessary to
> pass option -DEGL_API_FB. This option is declared in pkg-config file of
> Vivante library. But many packages (especialy qt5 components) does not
> consider these flags.
> 
> So instead of patching every packages that use EGL, it is more
> convenient to patch Vivante headers.
> 
> This commit add #define EGL_API_FB on top of eglvivante.h when
> necessary.
> 
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
> Tested-by: Gary Bisson <gary.bisson@boundarydevices.com>
> ---
>  package/freescale-imx/gpu-viv-bin-mx6q/egl.pc              |  2 +-
>  package/freescale-imx/gpu-viv-bin-mx6q/glesv2.pc           |  2 +-
>  package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk | 14 ++++++++++----
>  package/freescale-imx/gpu-viv-bin-mx6q/vg.pc               |  2 +-
>  4 files changed, 13 insertions(+), 7 deletions(-)
> 
> diff --git a/package/freescale-imx/gpu-viv-bin-mx6q/egl.pc b/package/freescale-imx/gpu-viv-bin-mx6q/egl.pc
> index c984247..d1d09a0 100644
> --- a/package/freescale-imx/gpu-viv-bin-mx6q/egl.pc
> +++ b/package/freescale-imx/gpu-viv-bin-mx6q/egl.pc
> @@ -7,4 +7,4 @@ Name: egl
>  Description: Freescale gpu-viv-bin-mx6q implementation of EGL
>  Version: 1.0
>  Libs: -L${libdir} -lGAL -lEGL
> -Cflags: -I${includedir}/ -DEGL_API_FB=1
> +Cflags: -I${includedir}/
> diff --git a/package/freescale-imx/gpu-viv-bin-mx6q/glesv2.pc b/package/freescale-imx/gpu-viv-bin-mx6q/glesv2.pc
> index 7cfb5e7..74ce792 100644
> --- a/package/freescale-imx/gpu-viv-bin-mx6q/glesv2.pc
> +++ b/package/freescale-imx/gpu-viv-bin-mx6q/glesv2.pc
> @@ -7,4 +7,4 @@ Name: glesv2
>  Description: Freescale gpu-viv-bin-mx6q implementation of OpenGL ESv2
>  Version: 2.0
>  Libs: -L${libdir} -lGAL -lEGL -lGLESv2
> -Cflags: -I${includedir}/ -DEGL_API_FB=1
> +Cflags: -I${includedir}/
> diff --git a/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk b/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk
> index 79c7a92..0304ba1 100644
> --- a/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk
> +++ b/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk
> @@ -46,16 +46,22 @@ define GPU_VIV_BIN_MX6Q_BUILD_CMDS
>  	ln -sf libGL.so.1.2 $(@D)/usr/lib/libGL.so.1.2.0
>  endef
>  
> +ifeq ($(GPU_VIV_BIN_MX6Q_LIB_TARGET),fb)
> +define GPU_VIV_BIN_MX6Q_FIXUP_FB_HEADERS
> +	$(SED) '/#define EGLAPIENTRY/ a \
> +		#if !defined(EGL_API_X11) && !defined(EGL_API_DFB) && !defined(EGL_API_FB) \n\
> +		#define EGL_API_FB \n\
> +		#endif' $(STAGING_DIR)/usr/include/EGL/eglvivante.h; \

Can you re-send this patch without the backslash at the end of the line
as it breaks the build (missing endif error)?

Regards,
Gary

  reply	other threads:[~2015-04-30 18:57 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30 15:12 [Buildroot] [PATCH v7 00/13] Add Xorg support for iMX6 Jérôme Pouiller
2015-04-30 15:12 ` [Buildroot] [PATCH v7 01/13] mesa3d: Give possibility to external backends to enable DRI/Gallium Jérôme Pouiller
2015-05-01 14:44   ` Thomas Petazzoni
2015-04-30 15:12 ` [Buildroot] [PATCH v7 02/13] gpu-viv-bin-mx6q: fix compiling issues with EGL_API_FB Jérôme Pouiller
2015-04-30 18:57   ` Gary Bisson [this message]
2015-04-30 20:08     ` [Buildroot] [PATCH v8] " Jérôme Pouiller
2015-05-01 14:44   ` [Buildroot] [PATCH v7 02/13] " Thomas Petazzoni
2015-04-30 15:12 ` [Buildroot] [PATCH v7 03/13] gpu-viv-bin-mx6q: make fb/x11 choice explicit Jérôme Pouiller
2015-05-01 14:45   ` Thomas Petazzoni
2015-04-30 15:12 ` [Buildroot] [PATCH v7 04/13] gpu-viv-bin-mx6q: remove useless build time deps Jérôme Pouiller
2015-05-01 14:45   ` Thomas Petazzoni
2015-04-30 15:12 ` [Buildroot] [PATCH v7 05/13] gpu-viv-bin-mx6q: add version in libraries symlinks Jérôme Pouiller
2015-05-01 14:45   ` Thomas Petazzoni
2015-04-30 15:12 ` [Buildroot] [PATCH v7 06/13] gpu-viv-bin-mx6q: change output selection mechanism Jérôme Pouiller
2015-05-01 14:45   ` Thomas Petazzoni
2015-04-30 15:12 ` [Buildroot] [PATCH v7 07/13] xdriver_xf86-video-imx-viv: new package Jérôme Pouiller
2015-05-01 14:48   ` Thomas Petazzoni
2015-04-30 15:12 ` [Buildroot] [PATCH v7 08/13] qt5base: fix compilation with Vivante headers Jérôme Pouiller
2015-05-01 20:49   ` Thomas Petazzoni
2015-04-30 15:12 ` [Buildroot] [PATCH v7 09/13] qt5base: fix "Unable to find an X11 visual" error Jérôme Pouiller
2015-05-01 20:50   ` Thomas Petazzoni
2015-04-30 15:12 ` [Buildroot] [PATCH v7 10/13] Vivante drivers: bump to version 3.10.17-1.0.1 Jérôme Pouiller
2015-05-01 20:51   ` Thomas Petazzoni
2015-05-04 15:12     ` Antoine Ténart
2015-05-04 15:15       ` Thomas Petazzoni
2015-05-05  8:06         ` Gary Bisson
2015-05-05  8:10           ` Thomas Petazzoni
2015-05-05  9:07             ` Gary Bisson
2015-05-05  9:13               ` Thomas Petazzoni
2015-05-05 22:14                 ` Gary Bisson
2015-05-11 13:23               ` Antoine Ténart
2015-05-11 16:32                 ` Gary Bisson
2015-05-11 17:48                   ` Jérôme Pouiller
2015-05-12  7:56                     ` Gary Bisson
2015-05-12  8:18                       ` Thomas Petazzoni
2015-05-05  9:15           ` Fabrice Mousset | GEOCEPT GmbH
2015-05-05  9:20             ` Gary Bisson
2015-05-05  9:58               ` Fabrice Mousset | GEOCEPT GmbH
2015-05-05 13:39                 ` Gary Bisson
2015-05-05 13:47                   ` Fabrice Mousset | GEOCEPT GmbH
2015-04-30 15:12 ` [Buildroot] [PATCH v7 11/13] nitrogen6x_defconfig: bump kernel to 3.10.17_1.0.1_ga Jérôme Pouiller
2015-05-01 20:51   ` Thomas Petazzoni
2015-04-30 15:12 ` [Buildroot] [PATCH v7 12/13] freescale_imx6*_defconfig: " Jérôme Pouiller
2015-05-01 20:52   ` Thomas Petazzoni
2015-04-30 15:12 ` [Buildroot] [PATCH v7 13/13] qmx6_defconfig: update Jérôme Pouiller
2015-05-01 20:53   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150430185716.GA8609@t450s.lan \
    --to=gary.bisson@boundarydevices.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.