All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Ming Lei <ming.lei@canonical.com>, Jens Axboe <axboe@kernel.dk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Justin M. Forbes" <jforbes@fedoraproject.org>,
	Jeff Moyer <jmoyer@redhat.com>, "v4.0" <stable@vger.kernel.org>
Subject: Re: [PATCH v6] block: loop: avoiding too many pending per work I/O
Date: Fri, 1 May 2015 11:47:13 -0400	[thread overview]
Message-ID: <20150501154713.GD1949@htj.duckdns.org> (raw)
In-Reply-To: <20150501150545.GA10705@infradead.org>

On Fri, May 01, 2015 at 08:05:45AM -0700, Christoph Hellwig wrote:
> > Maybe just cap max_active to NR_OF_LOOP_DEVS * 16 or sth?  But idk,
> > how many concurrent workers are we talking about and why are we
> > capping per-queue concurrency from worker pool side instead of command
> > tag side?
> 
> Also we probably should have per device workqueues to start with..

Yeah, that's an option.  The only thing is that each workqueue would
have to be tagged WQ_RESCUER and end up with separate rescuer task,
which usually isn't big a deal but there are setups where a lot of
loop devices are used and it may sting a bit.

Thanks.

-- 
tejun

  reply	other threads:[~2015-05-01 15:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01  3:28 [PATCH v6] block: loop: avoiding too many pending per work I/O Ming Lei
2015-05-01 10:17 ` Christoph Hellwig
2015-05-01 13:36   ` Ming Lei
2015-05-01 14:22     ` Tejun Heo
2015-05-01 15:05       ` Christoph Hellwig
2015-05-01 15:47         ` Tejun Heo [this message]
2015-05-02 15:09           ` Ming Lei
2015-05-02 14:56       ` Ming Lei
2015-05-03  1:52         ` Tejun Heo
2015-05-04 12:54           ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150501154713.GD1949@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=jforbes@fedoraproject.org \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@canonical.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.