From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] doc/manual: fix generating manual after legacy overhaul
Date: Fri, 1 May 2015 18:25:00 +0200 [thread overview]
Message-ID: <20150501162500.GG4206@free.fr> (raw)
In-Reply-To: <5543A1C9.2070801@mind.be>
Arnout, All,
On 2015-05-01 17:54 +0200, Arnout Vandecappelle spake thusly:
> On 01/05/15 17:06, Yann E. MORIN wrote:
[--SNIP--]
> > Also, slightly re-order variables so the ones we override come right
> > after the common settings, moving the specific pnes at the end.
> ones
>
> And split into one variable per line.
No, I did not want to explicitly set one variable per line.
The fact that BR2_DEFCONFIG and BR2_EXTERNAL are on their own line each
is just becasue the line would be more than 80-char wide otherwise.
But if you prefer I put a single vazriable per line, I'm OK with that; I
also prefer a single variable per line.
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Arnout Vandecappelle <arnout@mind.be>
> > ---
> > docs/manual/manual.mk | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/docs/manual/manual.mk b/docs/manual/manual.mk
> > index d5db2c2..2755582 100644
> > --- a/docs/manual/manual.mk
> > +++ b/docs/manual/manual.mk
> > @@ -12,8 +12,10 @@ MANUAL_RESOURCES = $(TOPDIR)/docs/images
> > # should not be included in the manual.
> > define MANUAL_GEN_LISTS
> > $(Q)$(call MESSAGE,"Updating the manual lists...")
> > - $(Q)BR2_DEFCONFIG="" TOPDIR=$(TOPDIR) O=$(@D) \
> > + $(Q)$(COMMON_CONFIG_ENV) \
> > + BR2_DEFCONFIG="" \
> > BR2_EXTERNAL=$(TOPDIR)/support/dummy-external \
> > + TOPDIR=$(TOPDIR) O=$(@D) \
>
> Except here you put two variables on a single line...
Because that was not the goal! ;-)
But I'll change.
Thanks! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2015-05-01 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 15:06 [Buildroot] [PATCH] doc/manual: fix generating manual after legacy overhaul Yann E. MORIN
2015-05-01 15:54 ` Arnout Vandecappelle
2015-05-01 16:25 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150501162500.GG4206@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.