From: Christoph Hellwig <hch@lst.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
Mike Snitzer <snitzer@redhat.com>,
Mike Christie <michaelc@cs.wisc.edu>
Subject: Re: [PATCH 3/9] dm-mpath: don't call scsi_dh_attach when we want to retain the attached handler
Date: Fri, 1 May 2015 18:46:24 +0200 [thread overview]
Message-ID: <20150501164624.GA16490@lst.de> (raw)
In-Reply-To: <yq1fv7guxa6.fsf@sermon.lab.mkp.net>
On Fri, May 01, 2015 at 11:34:25AM -0400, Martin K. Petersen wrote:
> + } else if (m->hw_handler_name) {
> /*
> * Increments scsi_dh reference, even when using an
> * already-attached handler.
>
> Shouldn't this comment be updated to reflect your previous patch?
Yes, it should. I'll fix it for the resend.
next prev parent reply other threads:[~2015-05-01 16:46 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 17:32 integrate scsi_dh better into the scsi core Christoph Hellwig
2015-04-30 17:32 ` [PATCH 1/9] dm-mpath: check kstrdup return value in parse_hw_handler Christoph Hellwig
2015-04-30 18:35 ` Hannes Reinecke
2015-05-01 13:57 ` Mike Snitzer
2015-05-01 15:07 ` Martin K. Petersen
2015-05-01 15:29 ` Martin K. Petersen
2015-04-30 17:32 ` [PATCH 2/9] dm-mpath, scsi_dh: don't let dm detach device handlers Christoph Hellwig
2015-04-30 18:21 ` Mike Snitzer
2015-05-01 9:20 ` Christoph Hellwig
2015-05-01 7:10 ` Hannes Reinecke
2015-05-01 13:58 ` Mike Snitzer
2015-05-01 15:30 ` Martin K. Petersen
2015-04-30 17:32 ` [PATCH 3/9] dm-mpath: don't call scsi_dh_attach when we want to retain the attached handler Christoph Hellwig
2015-04-30 18:25 ` Mike Snitzer
2015-05-01 7:10 ` Hannes Reinecke
2015-05-01 15:34 ` Martin K. Petersen
2015-05-01 16:46 ` Christoph Hellwig [this message]
2015-04-30 17:32 ` [PATCH 4/9] dm-mpath, scsi_dh: request scsi_dh modules in scsi_dh, not dm-mpath Christoph Hellwig
2015-04-30 18:28 ` Mike Snitzer
2015-05-01 7:11 ` Hannes Reinecke
2015-05-01 13:59 ` Mike Snitzer
2015-05-01 15:35 ` Martin K. Petersen
2015-04-30 17:32 ` [PATCH 5/9] scsi_dh: integrate into the core SCSI code Christoph Hellwig
2015-05-01 7:13 ` Hannes Reinecke
2015-05-01 15:36 ` Martin K. Petersen
2015-05-04 7:50 ` Hannes Reinecke
2015-05-05 15:25 ` Christoph Hellwig
2015-04-30 17:32 ` [PATCH 6/9] scsi_dh: move device matching to the core code Christoph Hellwig
2015-04-30 18:32 ` Mike Snitzer
2015-05-01 7:15 ` Hannes Reinecke
2015-05-01 15:39 ` Martin K. Petersen
2015-04-30 17:32 ` [PATCH 7/9] scsi_dh: kill struct scsi_dh_data Christoph Hellwig
2015-05-01 7:17 ` Hannes Reinecke
2015-05-01 15:41 ` Martin K. Petersen
2015-04-30 17:32 ` [PATCH 8/9] scsi_dh: add a common helper to get a scsi_device from a request_queue Christoph Hellwig
2015-05-01 7:18 ` Hannes Reinecke
2015-05-01 15:45 ` Martin K. Petersen
2015-04-30 17:32 ` [PATCH 9/9] scsi_dh: don't allow to detach device handlers at runtime Christoph Hellwig
2015-05-01 7:19 ` Hannes Reinecke
2015-05-01 15:46 ` Martin K. Petersen
2015-04-30 18:31 ` integrate scsi_dh better into the scsi core Mike Snitzer
2015-05-01 15:47 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150501164624.GA16490@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michaelc@cs.wisc.edu \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.