From: Lina Iyer <lina.iyer@linaro.org>
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: ohad@wizery.com, s-anna@ti.com, Bjorn.Andersson@sonymobile.com,
agross@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, galak@codeaurora.org
Subject: Re: [PATCH] hwspinlock: qcom: Lock #7 is special lock, uses dynamic proc_id
Date: Fri, 1 May 2015 11:31:17 -0600 [thread overview]
Message-ID: <20150501173117.GA7115@linaro.org> (raw)
In-Reply-To: <5543B779.8040109@codeaurora.org>
On Fri, May 01 2015 at 11:27 -0600, Jeffrey Hugo wrote:
>On 5/1/2015 11:06 AM, Lina Iyer wrote:
>
>>diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c
>>index 93b62e0..043c62c 100644
>>--- a/drivers/hwspinlock/qcom_hwspinlock.c
>>+++ b/drivers/hwspinlock/qcom_hwspinlock.c
>>@@ -25,16 +25,26 @@
>>
>> #include "hwspinlock_internal.h"
>>
>>-#define QCOM_MUTEX_APPS_PROC_ID 1
>>-#define QCOM_MUTEX_NUM_LOCKS 32
>>+#define QCOM_MUTEX_APPS_PROC_ID 1
>>+#define QCOM_MUTEX_CPUIDLE_OFFSET 128
>>+#define QCOM_CPUIDLE_LOCK 7
>>+#define QCOM_MUTEX_NUM_LOCKS 32
>>+
>
>This part of the diff doesn't look right. Why is it showing that
>QCOM_MUTEX_APPS_PROC_ID and QCOM_MUTEX_NUM_LOCKS are deleted and added
>lines? Shouldn't they be unchanged by this patch?
>
Sigh. I must have updated the tabs to play nice. Will fix in the next
spin.
Thanks for the review.
--Lina
>--
>Jeffrey Hugo
>Qualcomm Innovation Center, Inc.
>The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>Forum, a Linux Foundation Collaborative Project
prev parent reply other threads:[~2015-05-01 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 17:06 [PATCH] hwspinlock: qcom: Lock #7 is special lock, uses dynamic proc_id Lina Iyer
2015-05-01 17:27 ` Jeffrey Hugo
2015-05-01 17:31 ` Lina Iyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150501173117.GA7115@linaro.org \
--to=lina.iyer@linaro.org \
--cc=Bjorn.Andersson@sonymobile.com \
--cc=agross@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.