All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Simmons, James A." <simmonsja@ornl.gov>
Cc: 'Julia Lawall' <Julia.Lawall@lip6.fr>,
	Oleg Drokin <oleg.drokin@intel.com>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"HPDD-discuss@lists.01.org" <HPDD-discuss@ml01.01.org>
Subject: Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree
Date: Fri, 01 May 2015 18:05:30 +0000	[thread overview]
Message-ID: <20150501180530.GA26281@kroah.com> (raw)
In-Reply-To: <a650e757977e491b816c34e7780c1a08@EXCHCS32.ornl.gov>

On Fri, May 01, 2015 at 05:38:49PM +0000, Simmons, James A. wrote:
> >From: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> >Replace OBD_ALLOC, OBD_ALLOC_WAIT, OBD_ALLOC_PTR, and OBD_ALLOC_PTR_WAIT by
> >kalloc/kcalloc, and OBD_FREE and OBD_FREE_PTR by kfree.
> 
> Nak: James Simmons <jsimmons@infradead.org>
> 
> A simple replace will not work. The OBD_ALLOC and OBD_FREE functions allocate memory
> anywhere from one page to 4MB in size.

OBD_FREE() just calls kfree(), it does not allocate any memory, so that
replacement is always ok.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Simmons, James A." <simmonsja@ornl.gov>
Cc: "'Julia Lawall'" <Julia.Lawall@lip6.fr>,
	Oleg Drokin <oleg.drokin@intel.com>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"HPDD-discuss@lists.01.org" <HPDD-discuss@ml01.01.org>
Subject: Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree
Date: Fri, 1 May 2015 20:05:30 +0200	[thread overview]
Message-ID: <20150501180530.GA26281@kroah.com> (raw)
In-Reply-To: <a650e757977e491b816c34e7780c1a08@EXCHCS32.ornl.gov>

On Fri, May 01, 2015 at 05:38:49PM +0000, Simmons, James A. wrote:
> >From: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> >Replace OBD_ALLOC, OBD_ALLOC_WAIT, OBD_ALLOC_PTR, and OBD_ALLOC_PTR_WAIT by
> >kalloc/kcalloc, and OBD_FREE and OBD_FREE_PTR by kfree.
> 
> Nak: James Simmons <jsimmons@infradead.org>
> 
> A simple replace will not work. The OBD_ALLOC and OBD_FREE functions allocate memory
> anywhere from one page to 4MB in size.

OBD_FREE() just calls kfree(), it does not allocate any memory, so that
replacement is always ok.

thanks,

greg k-h

  parent reply	other threads:[~2015-05-01 18:05 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01 15:51 [PATCH 0/11] Use kzalloc and kfree Julia Lawall
2015-05-01 15:51 ` Julia Lawall
2015-05-01 15:51 ` [PATCH 11/11] staging: lustre: ptlrpc: " Julia Lawall
2015-05-01 15:51   ` Julia Lawall
2015-05-01 15:51 ` [PATCH 10/11] staging: lustre: osc: " Julia Lawall
2015-05-01 15:51   ` Julia Lawall
2015-05-01 15:51 ` [PATCH 9/11] staging: lustre: obdecho: " Julia Lawall
2015-05-01 15:51   ` Julia Lawall
2015-05-01 15:51 ` [PATCH 8/11] staging: lustre: obdclass: " Julia Lawall
2015-05-01 15:51   ` Julia Lawall
2015-05-01 18:30   ` walter harms
2015-05-01 18:30     ` walter harms
2015-05-01 18:42     ` Julia Lawall
2015-05-01 18:42       ` Julia Lawall
2015-05-01 15:51 ` [PATCH 7/11] staging: lustre: mgc: " Julia Lawall
2015-05-01 15:51   ` Julia Lawall
2015-05-01 15:51 ` [PATCH 6/11] staging: lustre: mdc: " Julia Lawall
2015-05-01 15:51   ` Julia Lawall
2015-05-01 15:51 ` [PATCH 5/11] staging: lustre: lmv: " Julia Lawall
2015-05-01 15:51   ` Julia Lawall
2015-05-01 15:51 ` [PATCH 4/11] staging: lustre: ldlm: " Julia Lawall
2015-05-01 15:51   ` Julia Lawall
2015-05-01 15:51 ` [PATCH 3/11] staging: lustre: lclient: " Julia Lawall
2015-05-01 15:51   ` Julia Lawall
2015-05-01 15:51 ` [PATCH 2/11] Staging: lustre: fld: " Julia Lawall
2015-05-01 15:51   ` Julia Lawall
2015-05-01 17:38   ` [HPDD-discuss] " Simmons, James A.
2015-05-01 17:38     ` Simmons, James A.
2015-05-01 17:48     ` Julia Lawall
2015-05-01 17:48       ` Julia Lawall
2015-05-01 18:49       ` Drokin, Oleg
2015-05-01 18:49         ` Drokin, Oleg
2015-05-01 20:18       ` Simmons, James A.
2015-05-01 20:18         ` Simmons, James A.
2015-05-01 20:47         ` Greg Kroah-Hartman
2015-05-01 20:47           ` Greg Kroah-Hartman
2015-05-01 22:57           ` Simmons, James A.
2015-05-01 22:57             ` Simmons, James A.
2015-05-01 20:49         ` Drokin, Oleg
2015-05-01 20:49           ` Drokin, Oleg
2015-05-01 22:59           ` Simmons, James A.
2015-05-01 22:59             ` Simmons, James A.
2015-05-01 18:05     ` Greg Kroah-Hartman [this message]
2015-05-01 18:05       ` Greg Kroah-Hartman
2015-05-01 20:02     ` Dan Carpenter
2015-05-01 20:02       ` Dan Carpenter
2015-05-01 20:12       ` Drokin, Oleg
2015-05-01 20:12         ` Drokin, Oleg
2015-05-01 20:36       ` Simmons, James A.
2015-05-01 20:36         ` Simmons, James A.
2015-05-01 20:49         ` Greg Kroah-Hartman
2015-05-01 20:49           ` Greg Kroah-Hartman
2015-05-01 20:52           ` Drokin, Oleg
2015-05-01 20:52             ` Drokin, Oleg
2015-05-01 20:58             ` Greg Kroah-Hartman
2015-05-01 20:58               ` Greg Kroah-Hartman
2015-05-01 21:13               ` Drokin, Oleg
2015-05-01 21:13                 ` Drokin, Oleg
2015-05-02  6:02                 ` Julia Lawall
2015-05-02  6:02                   ` Julia Lawall
2015-05-02  8:14                 ` Dan Carpenter
2015-05-02  8:14                   ` Dan Carpenter
2015-05-02  9:05                   ` Julia Lawall
2015-05-02  9:05                     ` Julia Lawall
2015-05-03  3:12                   ` Drokin, Oleg
2015-05-03  3:12                     ` Drokin, Oleg
2015-05-02  1:18     ` Simmons, James A.
2015-05-02  8:26     ` 'Greg Kroah-Hartman'
2015-05-02 17:17     ` Drokin, Oleg
2015-05-02 17:33     ` Greg Kroah-Hartman
2015-05-04 14:07     ` Simmons, James A.
2015-05-04 15:01     ` Dan Carpenter
2015-05-04 21:26     ` 'Greg Kroah-Hartman'
2015-05-01 15:51 ` [PATCH 1/11] staging: lustre: fid: " Julia Lawall
2015-05-01 15:51   ` Julia Lawall
2015-05-03 18:17 ` [PATCH 0/11] " Greg Kroah-Hartman
2015-05-03 18:17   ` Greg Kroah-Hartman
2015-05-03 18:39   ` Julia Lawall
2015-05-03 18:39     ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150501180530.GA26281@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=HPDD-discuss@ml01.01.org \
    --cc=Julia.Lawall@lip6.fr \
    --cc=devel@driverdev.osuosl.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    --cc=simmonsja@ornl.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.