From: Jeff King <peff@peff.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Josh Hagins <hagins.josh@gmail.com>,
Thiago Farina <tfransosi@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: multiple source file extensions
Date: Fri, 1 May 2015 22:33:21 -0400 [thread overview]
Message-ID: <20150502023320.GB587@peff.net> (raw)
In-Reply-To: <20150502020431.GA15775@lanh>
On Sat, May 02, 2015 at 09:04:32AM +0700, Duy Nguyen wrote:
> Subject: [PATCH] Avoid the need of "--" when wildcard pathspec is used
> [..]
> This patch modifies the rules a bit by considering any valid (*)
> wildcard pathspec "exist in worktree". The rules become:
>
> (1) if an arg is a rev, then it must either exist in worktree or not
> be a valid wildcard pathspec.
>
> (2) else, it either exists in worktree or is a wildcard pathspec
>
> (3) else, "--" is required.
>
> With the new rules, "--" is not needed most of the time when wildcard
> pathspec is involved.
I like it. Since this is a DWIM code path anyway, I don't think it
should be a problem in practice (i.e., if you are trying to do something
crazy like match a literal path that has a '*' in it, you really should
be using "--" in the first place).
-Peff
next prev parent reply other threads:[~2015-05-02 2:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 0:40 multiple source file extensions Thiago Farina
2015-05-02 0:49 ` Josh Hagins
2015-05-02 1:11 ` Jeff King
2015-05-02 2:04 ` Duy Nguyen
2015-05-02 2:11 ` Duy Nguyen
2015-05-02 2:35 ` Jeff King
2015-05-02 7:11 ` Eric Sunshine
2015-05-03 2:26 ` Junio C Hamano
2015-05-02 2:33 ` Jeff King [this message]
2015-05-04 22:12 ` Thiago Farina
2015-05-05 3:43 ` Jeff King
2015-05-05 17:30 ` Mikael Magnusson
2015-05-05 19:12 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150502023320.GB587@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=hagins.josh@gmail.com \
--cc=pclouds@gmail.com \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.