diff for duplicates of <20150502214707.GI14154@mwanda> diff --git a/a/1.txt b/N1/1.txt index 02e87e9..1cd6b42 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -18,16 +18,16 @@ On Sat, May 02, 2015 at 11:16:48PM +0200, Julia Lawall wrote: > +static inline void *obd_cpt_alloc(struct cfs_cpt_table *cptab, int cpt, > + size_t size, gfp_t flags) > +{ -> + return (cptab) = NULL ? +> + return (cptab) == NULL ? These parens aren't needed any more. -I feel like people shouldn't deliberately call this with dptab = NULL. +I feel like people shouldn't deliberately call this with dptab == NULL. I looked at it a bit and wasn't sure, (was sleepy though), so it's maybe safest to keep the test. I wish that cfs_cpt_spread_node() accepted NULL pointers so that we -didn't have to have the check for "cptab = NULL". But your patch seems +didn't have to have the check for "cptab == NULL". But your patch seems like the way forward for now. > + kzalloc(size, flags) : diff --git a/a/content_digest b/N1/content_digest index 957adeb..b2f6820 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01430601408-12847-1-git-send-email-Julia.Lawall@lip6.fr\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH] staging: lustre: obd_support: Add obd_cpt_alloc function\0" - "Date\0Sat, 02 May 2015 21:47:07 +0000\0" + "Date\0Sun, 3 May 2015 00:47:07 +0300\0" "To\0Julia Lawall <Julia.Lawall@lip6.fr>\0" "Cc\0Oleg Drokin <oleg.drokin@intel.com>" devel@driverdev.osuosl.org @@ -32,16 +32,16 @@ "> +static inline void *obd_cpt_alloc(struct cfs_cpt_table *cptab, int cpt,\n" "> +\t\t\t\t size_t size, gfp_t flags)\n" "> +{\n" - "> +\treturn (cptab) = NULL ?\n" + "> +\treturn (cptab) == NULL ?\n" "\n" "These parens aren't needed any more.\n" "\n" - "I feel like people shouldn't deliberately call this with dptab = NULL.\n" + "I feel like people shouldn't deliberately call this with dptab == NULL.\n" "I looked at it a bit and wasn't sure, (was sleepy though), so it's maybe\n" "safest to keep the test.\n" "\n" "I wish that cfs_cpt_spread_node() accepted NULL pointers so that we\n" - "didn't have to have the check for \"cptab = NULL\". But your patch seems\n" + "didn't have to have the check for \"cptab == NULL\". But your patch seems\n" "like the way forward for now.\n" "\n" "> +\t\tkzalloc(size, flags) :\n" @@ -52,4 +52,4 @@ "regards,\n" dan carpenter -6650d8d125ec87bdbb50d36d1dea3096cc7ee0c381e7e4df473173cfa32b905c +f90806e04b48a13e4f6bafd168e3b1741ed11d52bbcebf1ab10e052f53f62199
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.