From: Theodore Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "Jan Kara" <jack@suse.cz>,
linux-ext4@vger.kernel.org, "Lukáš Czerner" <lczerner@redhat.com>
Subject: Re: [PATCH v2] ext4: Fix growing of tiny filesystems
Date: Sun, 3 May 2015 00:00:38 -0400 [thread overview]
Message-ID: <20150503040038.GH10014@thunk.org> (raw)
In-Reply-To: <55423DAA.6020305@redhat.com>
On Thu, Apr 30, 2015 at 09:35:22AM -0500, Eric Sandeen wrote:
> On 4/30/15 2:06 AM, Jan Kara wrote:
> > The estimate of necessary transaction credits in ext4_flex_group_add()
> > is too pessimistic. It reserves credit for sb, resize inode, and resize
> > inode dindirect block for each group added in a flex group although they
> > are always the same block and thus it is enough to account them only
> > once. Also the number of modified GDT block is overestimated since we
> > fit EXT4_DESC_PER_BLOCK(sb) descriptors in one block.
> >
> > Make the estimation more precise. That reduces number of requested
> > credits enough that we can grow 20 MB filesystem (which has 1 MB
> > journal, 79 reserved GDT blocks, and flex group size 16 by default).
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
>
> Jan, thank you for looking into this and sorting it out.
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2015-05-03 4:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 7:06 [PATCH v2] ext4: Fix growing of tiny filesystems Jan Kara
2015-04-30 14:35 ` Eric Sandeen
2015-05-03 4:00 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150503040038.GH10014@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.