From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YonOm-0007qp-EY for mharc-grub-devel@gnu.org; Sun, 03 May 2015 02:29:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YonOk-0007qi-5d for grub-devel@gnu.org; Sun, 03 May 2015 02:29:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YonOg-0007GL-TG for grub-devel@gnu.org; Sun, 03 May 2015 02:29:06 -0400 Received: from mail-lb0-x22c.google.com ([2a00:1450:4010:c04::22c]:34973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YonOg-0007GH-K3 for grub-devel@gnu.org; Sun, 03 May 2015 02:29:02 -0400 Received: by lbbuc2 with SMTP id uc2so86710047lbb.2 for ; Sat, 02 May 2015 23:29:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=V6doImA/jycd6Sl0QVhFBF3irPA/j2zxrzM3eCKzypg=; b=oVRH3s+YL5QxCR+9zxOOsGfVJghc/3Hbboe38W+fT6Qoiaa7uXfNJIDC8PSeXxvvqp f9+YIW4XfPBcGEEPmiN7EiXQoqtujhaHg44HOodDG/fMgBY5gZ08S7lxTYq4LXzlIiWp f5NHxsPsgQaEd95duiz/zoWHMlODa4oq+IS/DJ8aQLr5YPGHfwZm4uccWBrRSL35EBJp BQdAN7BiMX7mciFZtKQ6Qyq8YvCZFM+ZrPx+qj3rdId3wixLn9sA8Z9sL8Sx8spiyZD6 IoaC0QNXC/0JO89W8Y78LjPO5PuGM6d2ldUt3oUzSFzD8vzBYaOUkil2aiEaJtMMYR+A Aidw== X-Received: by 10.112.163.168 with SMTP id yj8mr14633759lbb.36.1430634541799; Sat, 02 May 2015 23:29:01 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id m1sm2486593lbg.36.2015.05.02.23.28.59 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 May 2015 23:29:00 -0700 (PDT) Date: Sun, 3 May 2015 09:28:58 +0300 From: Andrei Borzenkov To: Jaegeuk Kim Subject: Re: [PATCH v2] F2FS support Message-ID: <20150503092858.016b3217@opensuse.site> In-Reply-To: <20150502201545.1ac3fead@opensuse.site> References: <1427185140-41120-1-git-send-email-jaegeuk@kernel.org> <20150403224908.GB25673@jaegeuk-mac02.mot.com> <20150502201545.1ac3fead@opensuse.site> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.27; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::22c Cc: grub-devel@gnu.org, linux-f2fs-devel@lists.sourceforge.net X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 May 2015 06:29:07 -0000 =D0=92 Sat, 2 May 2015 20:15:45 +0300 Andrei Borzenkov =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > + > > +static inline int > > +grub_generic_test_bit (int nr, const grub_uint32_t *addr) > > +{ > > + return 1UL & (addr[nr / 32] >> (nr & 31)); > > +} > > + >=20 > This is used only in grub_f2fs_check_dentries() with on-disk bitmap. > On-disk bitmap is little-endian; code is wrong on big-endian system. >=20 > Also dentry_bitmap is not multiple of 4 bytes as you replied earlier. > You should rather compute correct byte address instead and make all > parameters grub_uint8_t *. This will also avoid all those casts later. >=20 > That's really just >=20 > grub_uint8_t *addr; >=20 > byte =3D nr >> 3; > #ifdef WORDS_BIGENDIAN > byte ^=3D 3; > #endif Scratch it. We do know that byte order is LE so it is fixed. Sorry. > return addr[byte] & (1 << nr & 7); >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrei Borzenkov Subject: Re: [PATCH v2] F2FS support Date: Sun, 3 May 2015 09:28:58 +0300 Message-ID: <20150503092858.016b3217@opensuse.site> References: <1427185140-41120-1-git-send-email-jaegeuk@kernel.org> <20150403224908.GB25673@jaegeuk-mac02.mot.com> <20150502201545.1ac3fead@opensuse.site> Reply-To: The development of GNU GRUB Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150502201545.1ac3fead@opensuse.site> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org Sender: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org To: Jaegeuk Kim Cc: grub-devel@gnu.org, linux-f2fs-devel@lists.sourceforge.net List-Id: linux-f2fs-devel.lists.sourceforge.net 0JIgU2F0LCAyIE1heSAyMDE1IDIwOjE1OjQ1ICswMzAwCkFuZHJlaSBCb3J6ZW5rb3YgPGFydmlk amFhckBnbWFpbC5jb20+INC/0LjRiNC10YI6Cgo+ID4gKwo+ID4gK3N0YXRpYyBpbmxpbmUgaW50 Cj4gPiArZ3J1Yl9nZW5lcmljX3Rlc3RfYml0IChpbnQgbnIsIGNvbnN0IGdydWJfdWludDMyX3Qg KmFkZHIpCj4gPiArewo+ID4gKyAgcmV0dXJuIDFVTCAmIChhZGRyW25yIC8gMzJdID4+IChuciAm IDMxKSk7Cj4gPiArfQo+ID4gKwo+IAo+IFRoaXMgaXMgdXNlZCBvbmx5IGluIGdydWJfZjJmc19j aGVja19kZW50cmllcygpIHdpdGggb24tZGlzayBiaXRtYXAuCj4gT24tZGlzayBiaXRtYXAgaXMg bGl0dGxlLWVuZGlhbjsgY29kZSBpcyB3cm9uZyBvbiBiaWctZW5kaWFuIHN5c3RlbS4KPiAKPiBB bHNvIGRlbnRyeV9iaXRtYXAgaXMgbm90IG11bHRpcGxlIG9mIDQgYnl0ZXMgYXMgeW91IHJlcGxp ZWQgZWFybGllci4KPiBZb3Ugc2hvdWxkIHJhdGhlciBjb21wdXRlIGNvcnJlY3QgYnl0ZSBhZGRy ZXNzIGluc3RlYWQgYW5kIG1ha2UgYWxsCj4gcGFyYW1ldGVycyBncnViX3VpbnQ4X3QgKi4gVGhp cyB3aWxsIGFsc28gYXZvaWQgYWxsIHRob3NlIGNhc3RzIGxhdGVyLgo+IAo+IFRoYXQncyByZWFs bHkganVzdAo+IAo+ICAgZ3J1Yl91aW50OF90ICphZGRyOwo+IAo+ICAgYnl0ZSA9IG5yID4+IDM7 Cj4gI2lmZGVmIFdPUkRTX0JJR0VORElBTgo+ICAgYnl0ZSBePSAzOwo+ICNlbmRpZgoKU2NyYXRj aCBpdC4gV2UgZG8ga25vdyB0aGF0IGJ5dGUgb3JkZXIgaXMgTEUgc28gaXQgaXMgZml4ZWQuIFNv cnJ5LgoKPiAgIHJldHVybiBhZGRyW2J5dGVdICYgKDEgPDwgbnIgJiA3KTsKPiAKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkdydWItZGV2ZWwgbWFpbGlu ZyBsaXN0CkdydWItZGV2ZWxAZ251Lm9yZwpodHRwczovL2xpc3RzLmdudS5vcmcvbWFpbG1hbi9s aXN0aW5mby9ncnViLWRldmVsCg==