From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751665AbbECH4h (ORCPT ); Sun, 3 May 2015 03:56:37 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45379 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989AbbECH43 (ORCPT ); Sun, 3 May 2015 03:56:29 -0400 Date: Sun, 3 May 2015 09:56:25 +0200 From: Jean Delvare To: Sudip Mukherjee Cc: Greg KH , Dan Carpenter , One Thousand Gnomes , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 WIP 1/4] parport: add device-model to parport subsystem Message-ID: <20150503095625.3ca0530c@endymion.delvare> In-Reply-To: <20150503063733.GA12351@sudip-PC> References: <1430220623-8738-1-git-send-email-sudipm.mukherjee@gmail.com> <20150502162053.5dd0b1a8@endymion.delvare> <20150503063733.GA12351@sudip-PC> Organization: SUSE Linux X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sudip, On Sun, 3 May 2015 12:07:33 +0530, Sudip Mukherjee wrote: > On Sat, May 02, 2015 at 04:20:53PM +0200, Jean Delvare wrote: > > On Tue, 28 Apr 2015 17:00:20 +0530, Sudip Mukherjee wrote: > > > another WIP for your review. since this is not a formal patch for > > > applying so writing the comments here. > > > > You should still provide a proper description as if the patch was ready > > to be committed. Ultimately the descriptions are going to be part of > > the commits, so they need to be reviewed too. > > > > The history is good to have too for now, but it should go after the > > "---" separator, as it won't be part of the commit. > should i then send a v5 of WIP with proper commit message? Do not resend just for this. But please do it for the next iteration. > > > (...) > > > Signed-off-by: Sudip Mukherjee > > > --- > > > drivers/parport/parport_pc.c | 4 +- > > > drivers/parport/procfs.c | 15 ++- > > > drivers/parport/share.c | 266 ++++++++++++++++++++++++++++++++++++++++--- > > > include/linux/parport.h | 41 ++++++- > > > 4 files changed, 308 insertions(+), 18 deletions(-) > > > (...) > > > > Patch tested, no functional regression found. > > > > Tested-by: Jean Delvare > Thanks Jean. > Should i add your Tested-by: to the main patch and the patch > concerning the changes to i2c-parport? I have only tested the main patch at this point, I'll test the i2c-parport changes later today and report then. -- Jean Delvare SUSE L3 Support