From: Florian Westphal <fw@strlen.de>
To: Liu Hua <sdu.liu@huawei.com>
Cc: davem@davemloft.net, kadlec@blackhole.kfki.hu, kaber@trash.net,
pablo@netfilter.org, netfilter-devel@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
liusdu@126.com
Subject: Re: [PATCH] netfilter: fix dependency issues between IPv6 defragmentation and ip6tables
Date: Sun, 3 May 2015 13:07:15 +0200 [thread overview]
Message-ID: <20150503110715.GE22481@breakpoint.cc> (raw)
In-Reply-To: <1430646618-7625-1-git-send-email-sdu.liu@huawei.com>
Liu Hua <sdu.liu@huawei.com> wrote:
> commit f6318e558806c925029dc101f14874be9f9fa78f fix some related issue
> when ip6tables is enabled. But when IP6_NF_IPTABLES is disabled and
> NETFILTER_XT_TARGET_TPROXY is enabled. We will meet build failure with
> "net/built-in.o: In function `tproxy_tg_init':
> net/netfilter/xt_TPROXY.c:588: undefined reference to `nf_defrag_ipv6_enable'
> "
> So this patch change the Kconfig as ipv4 does.
> --- a/net/netfilter/Kconfig
> +++ b/net/netfilter/Kconfig
> @@ -865,7 +865,7 @@ config NETFILTER_XT_TARGET_TPROXY
> depends on (IPV6 || IPV6=n)
> depends on IP_NF_MANGLE
> select NF_DEFRAG_IPV4
> - select NF_DEFRAG_IPV6 if IP6_NF_IPTABLES
> + select NF_DEFRAG_IPV6
If IP6_NF_IPTABLES is not set, why would we have to pick
up IPV6 defragmentation?
Without ip6tables, TPROXY cannot be used for ipv6; in fact;
xt_TPROXY should be built without ipv6 support in this case.
My guess is that you have TPROXY=y but DEFRAG_IPV6=m, but that
might warrant a better fix (xt_socket seems to have same issue).
next prev parent reply other threads:[~2015-05-03 11:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-03 9:50 [PATCH] netfilter: fix dependency issues between IPv6 defragmentation and ip6tables Liu Hua
2015-05-03 11:07 ` Florian Westphal [this message]
2015-05-03 14:18 ` liusdu
2015-05-03 20:09 ` Florian Westphal
2015-05-03 20:09 ` Florian Westphal
2015-05-04 15:56 ` liusdu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150503110715.GE22481@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=liusdu@126.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=sdu.liu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.