From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Yop9j-0000fZ-2o for mharc-grub-devel@gnu.org; Sun, 03 May 2015 04:21:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yop9g-0000fS-J0 for grub-devel@gnu.org; Sun, 03 May 2015 04:21:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yop9d-0002na-Dd for grub-devel@gnu.org; Sun, 03 May 2015 04:21:40 -0400 Received: from mail-la0-x22d.google.com ([2a00:1450:4010:c03::22d]:34057) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yop9d-0002nS-5C for grub-devel@gnu.org; Sun, 03 May 2015 04:21:37 -0400 Received: by laat2 with SMTP id t2so86894854laa.1 for ; Sun, 03 May 2015 01:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:mime-version:content-type :content-transfer-encoding; bh=tdv/HNrzPcsLJotdwUayHvzzcZW9kpiMylxVmfxd9Bc=; b=vFOT/OzFiw7K18Exbse62LxmyVhUOXos/mA3LV6VpXGVIJ3YNYv2iHxC0193xnLR3i MiBhnnmG684Tqt2GLMXNWfkyV7vCvR6iXNzR5TenpNOL5pKPRmVkFWsuUOastdRPz8Pb u75XC1C/Wc3OyGmrlTR63FXkbc2eLIAH42pmOPDODW3PV1Y5gD+ueMeZpSdaj3RGXhb8 7zKVVSQUfW2einxYStyUhNRgAL/3UDrfZYY8ihVm+QkHo/HEcIsyyxDkZ68+6YM55GZr VfNVxPMhKd5HpH4wHlG6fdUW+Przyrmzj7i0O7Xu3HMCVl7816H/yysL6OcIb+piWIZs uxAg== X-Received: by 10.112.142.232 with SMTP id rz8mr14482506lbb.74.1430641296490; Sun, 03 May 2015 01:21:36 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id v6sm2546787laa.23.2015.05.03.01.21.34 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 May 2015 01:21:35 -0700 (PDT) Date: Sun, 3 May 2015 11:21:33 +0300 From: Andrei Borzenkov To: grub-devel@gnu.org Subject: Attempting to install GRUB to a disk with multiple partition labels or both partition label and filesystem. Message-ID: <20150503112133.2170d2e1@opensuse.site> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.27; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22d X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 May 2015 08:21:41 -0000 Could someone explain why this message is output here? It is absolutely not what condition checks for if (ctx.container && grub_strcmp (ctx.container->partmap->name, "msdos") == 0 && ctx.dest_partmap && (ctx.container->msdostype == GRUB_PC_PARTITION_TYPE_NETBSD || ctx.container->msdostype == GRUB_PC_PARTITION_TYPE_OPENBSD)) { grub_util_warn ("%s", _("Attempting to install GRUB to a disk with multiple partition labels or both partition label and filesystem. This is not supported yet.")); goto unable_to_embed; } Condition checks whether we are installing on a netbsd or openbsd partition with nested partition label. At this point we have really no idea whether any filesystem is present (we check for it later). So neither "multiple partition labels" nor "filesystem" appear to have anything to do with this check. Also it actually skips further sanity check for reserved sector in nested partition label and jumps directly to embedding. So it sounds like both error message is misleading and code is out of place (it probably should be moved after reserved sector check). Comments?