All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: "Jεan Sacren" <sakiwit@gmail.com>
Cc: netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next] sock: fix comment location
Date: Sun, 3 May 2015 23:05:34 +0200	[thread overview]
Message-ID: <20150503210534.GG22481@breakpoint.cc> (raw)
In-Reply-To: <1430686519-20548-1-git-send-email-sakiwit@gmail.com>

Jεan Sacren <sakiwit@gmail.com> wrote:
> From: Jean Sacren <sakiwit@gmail.com>
> 
> The block of comment is for 'sk_incoming_cpu' rather than 'sk_txhash'.
> Therefore, move it above "u16 sk_incoming_cpu;" where it belongs.

comment is at the right place.

> diff --git a/include/net/sock.h b/include/net/sock.h
> --- a/include/net/sock.h
> +++ b/include/net/sock.h
> -	u16			sk_incoming_cpu;
>  	/* 16bit hole
>  	 * Warned : sk_incoming_cpu can be set from softirq,
>  	 * Do not use this hole without fully understanding possible issues.
>  	 */
> +	u16			sk_incoming_cpu;

This hole is between sk_incoming_cpu and sk_txhash.

  reply	other threads:[~2015-05-03 21:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-03 20:55 [PATCH net-next] sock: fix comment location Jεan Sacren
2015-05-03 21:05 ` Florian Westphal [this message]
2015-05-03 21:11   ` Jεan Sacren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150503210534.GG22481@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=sakiwit@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.