From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752065AbbECUut (ORCPT ); Sun, 3 May 2015 16:50:49 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45194 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751727AbbECUum (ORCPT ); Sun, 3 May 2015 16:50:42 -0400 Date: Sun, 3 May 2015 22:50:37 +0200 From: Jean Delvare To: Sudip Mukherjee Cc: Greg KH , Dan Carpenter , One Thousand Gnomes , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 WIP 2/4] i2c-parport: modify driver to use new parport device model Message-ID: <20150503225037.51bdb1bd@endymion.delvare> In-Reply-To: <1430220623-8738-2-git-send-email-sudipm.mukherjee@gmail.com> References: <1430220623-8738-1-git-send-email-sudipm.mukherjee@gmail.com> <1430220623-8738-2-git-send-email-sudipm.mukherjee@gmail.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Apr 2015 17:00:21 +0530, Sudip Mukherjee wrote: > modify i2c-parport driver to use the new parallel port device model. > > v4: according to the suggestion of Alan, array is being used in the > module parameter. Hopefully no one will use more than 4 instances. > > Hi Jean, > This patchset is good for testing. Can you please check what is > happening to your hardware... > > Signed-off-by: Sudip Mukherjee > --- > drivers/i2c/busses/i2c-parport.c | 95 ++++++++++++++++++++++++++++------------ > drivers/i2c/busses/i2c-parport.h | 7 +++ > 2 files changed, 74 insertions(+), 28 deletions(-) > (...) Functional testing with a single device (ADM1032 eval board) went fine. I didn't test interrupts but as you didn't touch that part of the code I don't expect any specific problem. -- Jean Delvare SUSE L3 Support