All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Mc Guire <der.herr@hofr.at>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	Nicholas Mc Guire <hofrat@osadl.org>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 4/4] mtd: sh_flctl: fix wrapped condition alignment
Date: Mon, 4 May 2015 07:43:41 +0200	[thread overview]
Message-ID: <20150504054341.GA26350@opentech.at> (raw)
In-Reply-To: <20150504052138.GX3521@localhost>

On Mon, 04 May 2015, Vinod Koul wrote:

> On Sat, May 02, 2015 at 09:57:10AM +0200, Nicholas Mc Guire wrote:
> > CodingStyle fix only - align function parameters to opening (.
> > 
> This doesnt look any better to me...
>
True it makes little difference when looking at these few lines
I guess though the issue is consistency.
 
thx!
hofrat

WARNING: multiple messages have this Message-ID (diff)
From: Nicholas Mc Guire <der.herr@hofr.at>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Wolfram Sang <wsa@the-dreams.de>, Arnd Bergmann <arnd@arndb.de>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] mtd: sh_flctl: fix wrapped condition alignment
Date: Mon, 4 May 2015 07:43:41 +0200	[thread overview]
Message-ID: <20150504054341.GA26350@opentech.at> (raw)
In-Reply-To: <20150504052138.GX3521@localhost>

On Mon, 04 May 2015, Vinod Koul wrote:

> On Sat, May 02, 2015 at 09:57:10AM +0200, Nicholas Mc Guire wrote:
> > CodingStyle fix only - align function parameters to opening (.
> > 
> This doesnt look any better to me...
>
True it makes little difference when looking at these few lines
I guess though the issue is consistency.
 
thx!
hofrat

  reply	other threads:[~2015-05-04  5:44 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-02  7:57 [PATCH 1/4] mtd: sh_flctl: let flctl_dma_fifo0_transfer return 0 on success Nicholas Mc Guire
2015-05-02  7:57 ` Nicholas Mc Guire
2015-05-02  7:57 ` [PATCH 2/4] mtd: sh_flctl: drop unused variable Nicholas Mc Guire
2015-05-02  7:57   ` Nicholas Mc Guire
2015-05-03 19:33   ` Laurent Pinchart
2015-05-03 19:33     ` Laurent Pinchart
2015-05-04  5:17     ` Vinod Koul
2015-05-04  5:17       ` Vinod Koul
2015-05-04  6:03       ` Nicholas Mc Guire
2015-05-04  6:03         ` Nicholas Mc Guire
2015-05-04  7:53         ` Laurent Pinchart
2015-05-04  7:53           ` Laurent Pinchart
2015-05-10 13:49           ` Nicholas Mc Guire
2015-05-10 13:49             ` Nicholas Mc Guire
2015-05-02  7:57 ` [PATCH 3/4] mtd: sh_flctl: fix function parameter alignment Nicholas Mc Guire
2015-05-02  7:57   ` Nicholas Mc Guire
2015-05-02  7:57 ` [PATCH 4/4] mtd: sh_flctl: fix wrapped condition alignment Nicholas Mc Guire
2015-05-02  7:57   ` Nicholas Mc Guire
2015-05-04  5:21   ` Vinod Koul
2015-05-04  5:21     ` Vinod Koul
2015-05-04  5:43     ` Nicholas Mc Guire [this message]
2015-05-04  5:43       ` Nicholas Mc Guire
2015-05-04  7:05     ` Joe Perches
2015-05-04  7:05       ` Joe Perches
2015-05-03 19:35 ` [PATCH 1/4] mtd: sh_flctl: let flctl_dma_fifo0_transfer return 0 on success Laurent Pinchart
2015-05-03 19:35   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150504054341.GA26350@opentech.at \
    --to=der.herr@hofr.at \
    --cc=arnd@arndb.de \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=hofrat@osadl.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=vinod.koul@intel.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.