All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Pavel Šimerda" <pavlix@pavlix.net>
Cc: netdev@vger.kernel.org, psimerda@redhat.com
Subject: Re: [PATCH 5/7] ip-route: don't hide routes with RTM_F_CLONED by default
Date: Mon, 4 May 2015 08:37:51 -0700	[thread overview]
Message-ID: <20150504083751.7c38626b@urahara> (raw)
In-Reply-To: <1428933661-8193-5-git-send-email-pavlix@pavlix.net>

On Mon, 13 Apr 2015 16:00:59 +0200
Pavel Šimerda <pavlix@pavlix.net> wrote:

> From: Pavel Šimerda <psimerda@redhat.com>
> 
> Signed-off-by: Pavel Šimerda <psimerda@redhat.com>
> ---
>  ip/iproute.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I understand your concern, and it probably was a poor design choice initially.

Since this will change the output for the default case, it will upset some
peoples expectations and potentially break scripts that screen scrape the output
of ip commands. Therefore I can't accept it at this time.

Sorry for the delay, but I thought someone else would add more comments.
Perhaps if you explained in more detail the motivation of why this is an
important problem I would reconsider change the behavior.

  reply	other threads:[~2015-05-04 15:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-13 14:00 [PATCH 2/7] turn Makefile more distribution friendly Pavel Šimerda
2015-04-13 14:00 ` [PATCH 3/7] ip-xfrm: support 'proto any' with 'sport' and 'dport' Pavel Šimerda
2015-04-13 14:00 ` [PATCH 4/7] cbq: fix find syntax in example Pavel Šimerda
2015-04-13 14:00 ` [PATCH 5/7] ip-route: don't hide routes with RTM_F_CLONED by default Pavel Šimerda
2015-05-04 15:37   ` Stephen Hemminger [this message]
2015-05-04 18:37     ` David Miller
2015-05-11 17:48       ` Pavel Šimerda
2015-04-13 14:01 ` [PATCH 6/7] lnstat: dump to stdout, not stderr Pavel Šimerda
2015-04-13 14:01 ` [PATCH 7/7] lnstat: run indefinitely by default Pavel Šimerda
2015-04-20 16:55 ` [PATCH 2/7] turn Makefile more distribution friendly Stephen Hemminger
2015-04-21 15:32   ` Pavel Šimerda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150504083751.7c38626b@urahara \
    --to=stephen@networkplumber.org \
    --cc=netdev@vger.kernel.org \
    --cc=pavlix@pavlix.net \
    --cc=psimerda@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.