From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [autobuild v2 2/3] autobuild-run: also save CMake config log files on package failure
Date: Mon, 4 May 2015 22:12:37 +0200 [thread overview]
Message-ID: <20150504221237.6920abf7@free-electrons.com> (raw)
In-Reply-To: <5541613E.80604@mailerd.de>
Dear Andr? Erdmann,
On Thu, 30 Apr 2015 00:54:54 +0200, Andr? Erdmann wrote:
> config_files = set(('config.log', ...))
>
> It's negligible in terms of real time difference (<= 0.0d seconds),
> but for efficiency reasons, don't use a tuple or list when doing
> lookups ("fname in config_files").
>
> os.walk() might return 100s or 1000s of file names in total,
> and for each fname, you have to through the entire list/tuple
> (until fname found or end of list, whatever comes first).
> Data structures like set/frozenset/dict perform lookups faster (on average).
Can you submit a follow-up patch implementing this suggestion?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-05-04 20:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 20:10 [Buildroot] [autobuild v2 1/3] autobuild-run: prevent send_result from failing when gathering config files Samuel Martin
2015-04-29 20:10 ` [Buildroot] [autobuild v2 2/3] autobuild-run: also save CMake config log files on package failure Samuel Martin
2015-04-29 22:54 ` André Erdmann
2015-05-04 20:12 ` Thomas Petazzoni [this message]
2015-05-04 20:12 ` Thomas Petazzoni
2015-04-29 20:10 ` [Buildroot] [autobuild v2 3/3] autobuild-run: allow to change default git uri and branch on the command line Samuel Martin
2015-04-29 22:25 ` André Erdmann
2015-04-30 5:20 ` Samuel Martin
2015-04-30 18:20 ` André Erdmann
2015-05-04 20:11 ` Thomas Petazzoni
2015-05-04 20:12 ` [Buildroot] [autobuild v2 1/3] autobuild-run: prevent send_result from failing when gathering config files Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150504221237.6920abf7@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.