All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Ian Stakenvicius <axs@gentoo.org>
Cc: johan@kernel.org, linux-usb@vger.kernel.org,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cypress_m8: please add vendor/product id to support Prior Scientific OptiScan2
Date: Tue, 5 May 2015 09:35:17 +0200	[thread overview]
Message-ID: <20150505073517.GA23199@localhost> (raw)
In-Reply-To: <55479407.4050909@gentoo.org>

On Mon, May 04, 2015 at 11:45:11AM -0400, Ian Stakenvicius wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
> 
> The microscope automation controllers from Prior Scientific,
> specifically the OptiScan2 controller (the only one I have access to at
> present) use a Cypress CY7C64013-SXC for USB->serial conversion.  I've
> tested the following patch against drivers/usb/serial/cypress_m8.{c,h}
> with success (it just adds the vendor-id and product-id), and I was
> wondering if it could be added to the kernel?

Thanks for the patch. Please always run your patches through
scripts/checkpatch.pl before submitting, it would have told you that you
forgot to sign-off.

You should include the patch inline in your mail rather than as an
attachment (also read Documentation/SubmittingPatches). git format-patch
and send-mail can be quite useful.

An example of what such a patch could look like can be found here:

	http://www.spinics.net/lists/linux-usb/msg123868.html

Care to fix that up and resend?

Thanks,
Johan

      reply	other threads:[~2015-05-05  7:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-04 15:45 [PATCH] cypress_m8: please add vendor/product id to support Prior Scientific OptiScan2 Ian Stakenvicius
2015-05-05  7:35 ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150505073517.GA23199@localhost \
    --to=johan@kernel.org \
    --cc=axs@gentoo.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.