From: Peter Zijlstra <peterz@infradead.org>
To: Michael Turquette <mturquette@linaro.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
preeti@linux.vnet.ibm.com, Morten.Rasmussen@arm.com,
riel@redhat.com, efault@gmx.de, nicolas.pitre@linaro.org,
inaro-kernel@lists.linaro.org, daniel.lezcano@linaro.org,
patches@linaro.org, eas-dev@lists.linaro.org,
dietmar.eggemann@arm.com, vincent.guittot@linaro.org,
amit.kucheria@linaro.org, juri.lelli@arm.com, rjw@rjwysocki.net,
viresh.kumar@linaro.org, ashwin.chaugule@linaro.org,
alex.shi@linaro.org
Subject: Re: [PATCH 4/4] sched: cpufreq_cfs: pelt-based cpu frequency scaling
Date: Tue, 5 May 2015 11:00:42 +0200 [thread overview]
Message-ID: <20150505090042.GC21418@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1430777441-15087-5-git-send-email-mturquette@linaro.org>
On Mon, May 04, 2015 at 03:10:41PM -0700, Michael Turquette wrote:
> This policy is implemented using the cpufreq governor interface for two
> main reasons:
>
> 1) re-using the cpufreq machine drivers without using the governor
> interface is hard.
>
> 2) using the cpufreq interface allows us to switch between the
> scheduler-driven policy and legacy cpufreq governors such as ondemand at
> run-time. This is very useful for comparative testing and tuning.
Urgh,. so I don't really like that. It adds a lot of noise to the
system. You do the irq work thing to kick the cpufreq threads which do
their little thing -- and their wakeup will influence the cfs
accounting, which in turn will start the whole thing anew.
I would really prefer you did a whole new system with directly invoked
drivers that avoid the silly dance. Your 'new' ARM systems should be
well capable of that.
You can still do 2 if you create a cpufreq off switch. You can then
either enable the sched one or the legacy cpufreq -- or both if you want
a trainwreck ;-)
As to the drivers, they're mostly fairly small and self contained, it
should not be too hard to hack them up to work without cpufreq.
next prev parent reply other threads:[~2015-05-05 9:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 22:10 [PATCH 0/4] scheduler-based cpu frequency scaling Michael Turquette
2015-05-04 22:10 ` [PATCH 1/4] arm: Frequency invariant scheduler load-tracking support Michael Turquette
2015-05-04 22:10 ` [PATCH 2/4] sched: sched feature for cpu frequency selection Michael Turquette
2015-05-04 22:10 ` [PATCH 3/4] sched: export get_cpu_usage & capacity_orig_of Michael Turquette
2015-05-04 22:10 ` [PATCH 4/4] sched: cpufreq_cfs: pelt-based cpu frequency scaling Michael Turquette
2015-05-05 9:00 ` Peter Zijlstra [this message]
2015-05-05 12:16 ` Juri Lelli
[not found] ` <20150505182347.16410.16338@quantum>
2015-05-06 12:22 ` Peter Zijlstra
[not found] ` <20150507041725.16410.58417@quantum>
2015-05-07 6:23 ` Peter Zijlstra
2015-05-07 10:49 ` Juri Lelli
2015-05-07 14:25 ` Michael Turquette
2015-05-05 9:01 ` Peter Zijlstra
2015-05-05 9:04 ` Peter Zijlstra
2015-05-04 23:27 ` [PATCH 0/4] scheduler-based " Rafael J. Wysocki
2015-05-05 18:28 ` Mike Turquette
2015-05-06 16:50 ` [PATCH] sched/core: Add empty 'gov_cfs_update_cpu' function definition for NON-SMP systems Abel Vesa
2015-05-07 4:18 ` Michael Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150505090042.GC21418@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Morten.Rasmussen@arm.com \
--cc=alex.shi@linaro.org \
--cc=amit.kucheria@linaro.org \
--cc=ashwin.chaugule@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=eas-dev@lists.linaro.org \
--cc=efault@gmx.de \
--cc=inaro-kernel@lists.linaro.org \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mturquette@linaro.org \
--cc=nicolas.pitre@linaro.org \
--cc=patches@linaro.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.