From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH 1/8] gpiolib: Add support for removing registered consumer lookup table Date: Tue, 5 May 2015 17:44:59 +0200 Message-ID: <20150505154459.GC30184@phenom.ffwll.local> References: <1430316005-16480-2-git-send-email-shobhit.kumar@intel.com> <1430818368-26790-1-git-send-email-shobhit.kumar@intel.com> <20150505104505.GZ4047@x1> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20150505104505.GZ4047@x1> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lee Jones Cc: Alexandre Courbot , Samuel Ortiz , linux-pwm , Jani Nikula , Shobhit Kumar , intel-gfx , linux-kernel , Povilas Staniulis , dri-devel , linux-gpio , Daniel Vetter List-Id: linux-gpio@vger.kernel.org T24gVHVlLCBNYXkgMDUsIDIwMTUgYXQgMTE6NDU6MDVBTSArMDEwMCwgTGVlIEpvbmVzIHdyb3Rl Ogo+IFRoaXMgaXMgbm90IGhvdyB3ZSBzdWJtaXQgc3Vic2VxdWVudCBwYXRjaC1zZXRzLgoKSXQg aXMgdW5mb3J0dW5hdGVseSBob3cgd2UgaGFuZGxlIHBhdGNoZXMgb24gZHJpLWRldmVsJmludGVs LWdmeCB0byBiZQphYmxlIHRvIGNvcGUgd2l0aCBtYXNzaXZlIG1haWwgbG9hZC4gSWYgZXZlcnlv bmUgd2hvIHN1Ym1pdHMgdG8gaW50ZWwtZ2Z4CndvdWxkIGFsd2F5cyByZXNlbmQgdGhlIGVudGly ZSBzZXJpZXMgZm9yIG1pbm9yIHVwZGF0ZXMgb2Ygc29tIHBhdGNoZXMKd2UnZCBjb21wbGV0ZWx5 IGRyb3duIGluIHRoZSByZXN1bHRpbmcgZmxvb2QuCgo+IFBsZWFzZSBzdWJtaXQgdGhlbSBhcyBh IHdob2xlLCBzZXBlcmF0ZWx5IGZyb20gdGhlIGZpcnN0IHN1Ym1pc3Npb24KPiBhbmQgd2l0aCB2 ZXJzaW9uaW5nIGluZm9ybWF0aW9uIGkuZS4gW1BBVENIIHYyIFgvWV0gU3R1ZmYgLi4uCj4gCj4g PiBJbiBjYXNlIHdlIHVubG9hZCBhbmQgbG9hZCBhIGRyaXZlciBtb2R1bGUgYWdhaW4gdGhhdCBp cyByZWdpc3RlcmluZyBhCj4gPiBsb29rdXAgdGFibGUsIHdpdGhvdXQgdGhpcyBpdCB3aWxsIHJl c3VsdCBpbiBtdWx0aXBsZSBlbnRyaWVzLiBQcm92aWRlCj4gPiBhbiBvcHRpb24gdG8gcmVtb3Zl IHRoZSBsb29rdXAgdGFibGUgb24gZHJpdmVyIHVubG9hZAo+ID4gCj4gPiB2MjogQ2NpbmcgbWFp bnRhaW5lcnMKPiA+IHYzOiBDb3JyZWN0IHRoZSBzdWJqZWN0IGxpbmUgKExlZSBqb25lcykKPiAK PiBDaGFuZ2UgbG9ncyBzaG91bGQgZ28gdW5kZXJuZXRoIHRoZSAnLS0tJyBhbmQgYWJvdmUgdGhl IGRpZmZzdGF0IGZvdW5kCj4gYmVsb3cuCgpBZ2FpbiBqdXN0IHN0eWxlIGRpZmZlcmVuY2VzIGJl dHdlZW4gc3Vic3lzdGVtcywgSSBnZW5lcmFsbHkgd2FudCB0byBoYXZlCnRob3NlIGFib3ZlIHRo ZSAtLS0uCi1EYW5pZWwKPiAKPiA+IENjOiBTYW11ZWwgT3J0aXogPHNhbWVvQGxpbnV4LmludGVs LmNvbT4KPiA+IENjOiBMaW51cyBXYWxsZWlqIDxsaW51cy53YWxsZWlqQGxpbmFyby5vcmc+Cj4g PiBDYzogQWxleGFuZHJlIENvdXJib3QgPGdudXJvdUBnbWFpbC5jb20+Cj4gPiBDYzogVGhpZXJy eSBSZWRpbmcgPHRoaWVycnkucmVkaW5nQGdtYWlsLmNvbT4KPiA+IFJldmlld2VkLWJ5OiBBbGV4 YW5kcmUgQ291cmJvdCA8YWNvdXJib3RAbnZpZGlhLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IFNo b2JoaXQgS3VtYXIgPHNob2JoaXQua3VtYXJAaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVy cy9ncGlvL2dwaW9saWIuYyAgICAgICB8IDEzICsrKysrKysrKysrKysKPiA+ICBpbmNsdWRlL2xp bnV4L2dwaW8vbWFjaGluZS5oIHwgIDEgKwo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0 aW9ucygrKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncGlvL2dwaW9saWIuYyBiL2Ry aXZlcnMvZ3Bpby9ncGlvbGliLmMKPiA+IGluZGV4IDU5ZWFhMjMuLjI0MjBhZjkgMTAwNjQ0Cj4g PiAtLS0gYS9kcml2ZXJzL2dwaW8vZ3Bpb2xpYi5jCj4gPiArKysgYi9kcml2ZXJzL2dwaW8vZ3Bp b2xpYi5jCj4gPiBAQCAtMTY1OCw2ICsxNjU4LDE5IEBAIHZvaWQgZ3Bpb2RfYWRkX2xvb2t1cF90 YWJsZShzdHJ1Y3QgZ3Bpb2RfbG9va3VwX3RhYmxlICp0YWJsZSkKPiA+ICAJbXV0ZXhfdW5sb2Nr KCZncGlvX2xvb2t1cF9sb2NrKTsKPiA+ICB9Cj4gPiAgCj4gPiArLyoqCj4gPiArICogZ3Bpb2Rf cmVtb3ZlX2xvb2t1cF90YWJsZSgpIC0gdW5yZWdpc3RlciBHUElPIGRldmljZSBjb25zdW1lcnMK PiA+ICsgKiBAdGFibGU6IHRhYmxlIG9mIGNvbnN1bWVycyB0byB1bnJlZ2lzdGVyCj4gPiArICov Cj4gPiArdm9pZCBncGlvZF9yZW1vdmVfbG9va3VwX3RhYmxlKHN0cnVjdCBncGlvZF9sb29rdXBf dGFibGUgKnRhYmxlKQo+ID4gK3sKPiA+ICsJbXV0ZXhfbG9jaygmZ3Bpb19sb29rdXBfbG9jayk7 Cj4gPiArCj4gPiArCWxpc3RfZGVsKCZ0YWJsZS0+bGlzdCk7Cj4gPiArCj4gPiArCW11dGV4X3Vu bG9jaygmZ3Bpb19sb29rdXBfbG9jayk7Cj4gPiArfQo+ID4gKwo+ID4gIHN0YXRpYyBzdHJ1Y3Qg Z3Bpb19kZXNjICpvZl9maW5kX2dwaW8oc3RydWN0IGRldmljZSAqZGV2LCBjb25zdCBjaGFyICpj b25faWQsCj4gPiAgCQkJCSAgICAgIHVuc2lnbmVkIGludCBpZHgsCj4gPiAgCQkJCSAgICAgIGVu dW0gZ3Bpb19sb29rdXBfZmxhZ3MgKmZsYWdzKQo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGlu dXgvZ3Bpby9tYWNoaW5lLmggYi9pbmNsdWRlL2xpbnV4L2dwaW8vbWFjaGluZS5oCj4gPiBpbmRl eCBlMjcwNjE0Li5jMGQ3MTJkIDEwMDY0NAo+ID4gLS0tIGEvaW5jbHVkZS9saW51eC9ncGlvL21h Y2hpbmUuaAo+ID4gKysrIGIvaW5jbHVkZS9saW51eC9ncGlvL21hY2hpbmUuaAo+ID4gQEAgLTU3 LDUgKzU3LDYgQEAgc3RydWN0IGdwaW9kX2xvb2t1cF90YWJsZSB7Cj4gPiAgfQo+ID4gIAo+ID4g IHZvaWQgZ3Bpb2RfYWRkX2xvb2t1cF90YWJsZShzdHJ1Y3QgZ3Bpb2RfbG9va3VwX3RhYmxlICp0 YWJsZSk7Cj4gPiArdm9pZCBncGlvZF9yZW1vdmVfbG9va3VwX3RhYmxlKHN0cnVjdCBncGlvZF9s b29rdXBfdGFibGUgKnRhYmxlKTsKPiA+ICAKPiA+ICAjZW5kaWYgLyogX19MSU5VWF9HUElPX01B Q0hJTkVfSCAqLwo+IAo+IC0tIAo+IExlZSBKb25lcwo+IExpbmFybyBTVE1pY3JvZWxlY3Ryb25p Y3MgTGFuZGluZyBUZWFtIExlYWQKPiBMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2Fy ZSBmb3IgQVJNIFNvQ3MKPiBGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9n Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRl bC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0t IApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRw Oi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760156AbbEEQLE (ORCPT ); Tue, 5 May 2015 12:11:04 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:35938 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2993437AbbEEPmm (ORCPT ); Tue, 5 May 2015 11:42:42 -0400 Date: Tue, 5 May 2015 17:44:59 +0200 From: Daniel Vetter To: Lee Jones Cc: Shobhit Kumar , linux-pwm , Jani Nikula , Samuel Ortiz , Alexandre Courbot , David Airlie , Povilas Staniulis , intel-gfx , linux-kernel , dri-devel , linux-gpio , Chih-Wei Huang , Thierry Reding , Daniel Vetter , Linus Walleij Subject: Re: [Intel-gfx] [PATCH 1/8] gpiolib: Add support for removing registered consumer lookup table Message-ID: <20150505154459.GC30184@phenom.ffwll.local> Mail-Followup-To: Lee Jones , Shobhit Kumar , linux-pwm , Jani Nikula , Samuel Ortiz , Alexandre Courbot , David Airlie , Povilas Staniulis , intel-gfx , linux-kernel , dri-devel , linux-gpio , Chih-Wei Huang , Thierry Reding , Daniel Vetter , Linus Walleij References: <1430316005-16480-2-git-send-email-shobhit.kumar@intel.com> <1430818368-26790-1-git-send-email-shobhit.kumar@intel.com> <20150505104505.GZ4047@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150505104505.GZ4047@x1> X-Operating-System: Linux phenom 4.0.0-rc3+ User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 05, 2015 at 11:45:05AM +0100, Lee Jones wrote: > This is not how we submit subsequent patch-sets. It is unfortunately how we handle patches on dri-devel&intel-gfx to be able to cope with massive mail load. If everyone who submits to intel-gfx would always resend the entire series for minor updates of som patches we'd completely drown in the resulting flood. > Please submit them as a whole, seperately from the first submission > and with versioning information i.e. [PATCH v2 X/Y] Stuff ... > > > In case we unload and load a driver module again that is registering a > > lookup table, without this it will result in multiple entries. Provide > > an option to remove the lookup table on driver unload > > > > v2: Ccing maintainers > > v3: Correct the subject line (Lee jones) > > Change logs should go underneth the '---' and above the diffstat found > below. Again just style differences between subsystems, I generally want to have those above the ---. -Daniel > > > Cc: Samuel Ortiz > > Cc: Linus Walleij > > Cc: Alexandre Courbot > > Cc: Thierry Reding > > Reviewed-by: Alexandre Courbot > > Signed-off-by: Shobhit Kumar > > --- > > drivers/gpio/gpiolib.c | 13 +++++++++++++ > > include/linux/gpio/machine.h | 1 + > > 2 files changed, 14 insertions(+) > > > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > > index 59eaa23..2420af9 100644 > > --- a/drivers/gpio/gpiolib.c > > +++ b/drivers/gpio/gpiolib.c > > @@ -1658,6 +1658,19 @@ void gpiod_add_lookup_table(struct gpiod_lookup_table *table) > > mutex_unlock(&gpio_lookup_lock); > > } > > > > +/** > > + * gpiod_remove_lookup_table() - unregister GPIO device consumers > > + * @table: table of consumers to unregister > > + */ > > +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) > > +{ > > + mutex_lock(&gpio_lookup_lock); > > + > > + list_del(&table->list); > > + > > + mutex_unlock(&gpio_lookup_lock); > > +} > > + > > static struct gpio_desc *of_find_gpio(struct device *dev, const char *con_id, > > unsigned int idx, > > enum gpio_lookup_flags *flags) > > diff --git a/include/linux/gpio/machine.h b/include/linux/gpio/machine.h > > index e270614..c0d712d 100644 > > --- a/include/linux/gpio/machine.h > > +++ b/include/linux/gpio/machine.h > > @@ -57,5 +57,6 @@ struct gpiod_lookup_table { > > } > > > > void gpiod_add_lookup_table(struct gpiod_lookup_table *table); > > +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table); > > > > #endif /* __LINUX_GPIO_MACHINE_H */ > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch