From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH 02/13] KVM: reuse memslot in kvm_write_guest_page
Date: Tue, 5 May 2015 18:29:55 +0200
Message-ID: <20150505162954.GA17198@potion.brq.redhat.com>
References: <1430393772-27208-1-git-send-email-pbonzini@redhat.com>
 <1430393772-27208-3-git-send-email-pbonzini@redhat.com>
 <jpgegmvoym9.fsf@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Paolo Bonzini <pbonzini@redhat.com>, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org, guangrong.xiao@linux.intel.com,
	Yang Zhang <yang.z.zhang@intel.com>, wanpeng.li@linux.intel.com
To: Bandan Das <bsd@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <jpgegmvoym9.fsf@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

2015-05-05 11:03-0400, Bandan Das:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>=20
>> From: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>
>>
>> Saves one O(log N) search.
>=20
> It really doesn't hurt to change this to:
> "Caching memslot value helps us avoid another O(log N) search
> later when calling mark_page_dirty_in_slot()."
>=20
> Sorry I am not a fan of commit messages less than 75 characters :)

Sure, I just couldn't find a message that would be easier to understand
than the code and not misleading at the same time ... what came out was
a teaser for people who care about performance :)

In verbose mode, I'd write it like this:
  gfn_to_hva() and mark_page_dirty() both call gfn_to_memslot().
  We can store a result of gfn_to_memslot() (memslot) and unwrap
  gfn_to_hva() and mark_page_dirty() to directly call functions that
  accept a memslot.
  gfn_to_memslot() does a binary search, so it also saves some cycles.